[GitHub] [helix] rahulrane50 commented on a diff in pull request #2470: code clean up - debug log format

["rahulrane50 (via GitHub)" <gi...@apache.org>]

rahulrane50 commented on code in PR #2470:
URL: https://github.com/apache/helix/pull/2470#discussion_r1189123288


##########
helix-core/src/main/java/org/apache/helix/spectator/RoutingDataCache.java:
##########
@@ -130,23 +130,21 @@ public synchronized void refresh(HelixDataAccessor accessor) {
         }
         _propertyDataChangedMap.put(HelixConstants.ChangeType.CUSTOMIZED_VIEW, false);
       }
-        break;
-      default:
-        break;
+      break;
+        default:
+          break;
       }
     }
     long endTime = System.currentTimeMillis();
     LOG.info("END: RoutingDataCache.refresh() for cluster " + _clusterName + ", took " + (endTime
         - startTime) + " ms");
 
-    if (LOG.isDebugEnabled()) {

Review Comment:
   May be we want to keep this because if debug mode is not enabled then we won't even iterate on _sourceDataTypeMap below.



##########
helix-core/src/main/java/org/apache/helix/spectator/RoutingDataCache.java:
##########
@@ -130,23 +130,21 @@ public synchronized void refresh(HelixDataAccessor accessor) {
         }
         _propertyDataChangedMap.put(HelixConstants.ChangeType.CUSTOMIZED_VIEW, false);
       }
-        break;
-      default:
-        break;
+      break;
+        default:

Review Comment:
   nit : can remove this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org