You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/05 09:37:00 UTC
[jira] [Commented] (NIFI-5156) Update 'Google Cloud SDK' version
and refactor GCP processors' code
[ https://issues.apache.org/jira/browse/NIFI-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464719#comment-16464719 ]
ASF GitHub Bot commented on NIFI-5156:
--------------------------------------
GitHub user zenfenan opened a pull request:
https://github.com/apache/nifi/pull/2680
NIFI-5156: Updated GCP SDK to latest version
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zenfenan/nifi NIFI-5156
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2680.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2680
----
commit 4f388adf2781fd82190d65b1035a8a41e1a70c1c
Author: zenfenan <si...@...>
Date: 2018-05-05T09:15:40Z
NIFI-5156: Updated GCP SDK to latest version
----
> Update 'Google Cloud SDK' version and refactor GCP processors' code
> -------------------------------------------------------------------
>
> Key: NIFI-5156
> URL: https://issues.apache.org/jira/browse/NIFI-5156
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Sivaprasanna Sethuraman
> Assignee: Sivaprasanna Sethuraman
> Priority: Major
>
> The current version of nifi-gcp-bundle has the following problems:
> # It is of a very old version
> # The bundle uses [google-cloud|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/pom.xml#L65-L82] which is a uber/fat jar that comes with all google-cloud-java SDKs making the overall NAR bundle heavy.
> The following improvements are identified and have to be made:
> * Update the SDK to a more recent version
> * Introduce google-cloud-bom and then use the necessary SDK (storage, bigquery, etc) as and when needed, thus reducing the overall NAR size.
> * Refactor and make necessary changes to the current version of GCS processors, if needed because of the update
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)