[GitHub] [mynewt-core] KKopyscinski edited a comment on pull request #2457: [RFC] coap: negation in tcp check in coap_receive()

[GitBox <gi...@apache.org>]

KKopyscinski edited a comment on pull request #2457:
URL: https://github.com/apache/mynewt-core/pull/2457#issuecomment-764631233


   Sample logs illustrating the issue:
   - Without patch
   ```003019 [ts=23585900us, mod=4 level=0 ]ble_hs_hci_evt_acl_process(): conn_handle=1 pb=2 len=17 data=0x0d 0x00 0x04 0x00 0x12 0x0c 0x00 0x71 0xe1 0x01 0xff 0x73 0x61 0x6d 0x70 0x6c 0x65 
   003019 [ts=23585900us, mod=7 level=0 ]oc_gatt rx seg 1-200014bc-10
   003019 [ts=23585900us, mod=4 level=0 ]host tx hci data; handle=1 length=5
   003019 [ts=23585900us, mod=4 level=0 ]ble_hs_hci_acl_tx(): 0x01 0x00 0x05 0x00 0x01 0x00 0x04 0x00 0x13 
   003019 [ts=23585900us, mod=7 level=0 ]oc_buffer_rx: CoAP: received datalen=10
   003020 [ts=23593712us, mod=7 level=0 ]Token (len 1)   Parsed: CoAP version: 0, token: 0x0100, mid: 0
   003020 [ts=23593712us, mod=7 level=0 ]  type: CON
   ```
   
   - With patch (send service not supported)
   
   ```
   001646 [ts=12859320us, mod=4 level=0 ]ble_hs_hci_evt_acl_process(): conn_handle=1 pb=2 len=17 data=0x0d 0x00 0x04 0x00 0x12 0x0c 0x00 0x71 0xe1 0x01 0xff 0x73 0x61 0x6d 0x70 0x6c 0x65 
   001646 [ts=12859320us, mod=7 level=0 ]oc_gatt rx seg 1-200014bc-10
   001646 [ts=12859320us, mod=4 level=0 ]host tx hci data; handle=1 length=5
   001646 [ts=12859320us, mod=4 level=0 ]ble_hs_hci_acl_tx(): 0x01 0x00 0x05 0x00 0x01 0x00 0x04 0x00 0x13 
   001646 [ts=12859320us, mod=7 level=0 ]oc_buffer_rx: CoAP: received datalen=10
   001646 [ts=12859320us, mod=7 level=0 ]Token (len 1)   Parsed: CoAP version: 0, token: 0x0100, mid: 0
   001647 [ts=12867132us, mod=7 level=0 ]  type: CON
   001647 [ts=12867132us, mod=7 level=0 ]coap_tx: 0x20001544
   001647 [ts=12867132us, mod=7 level=0 ]coap_tx: serialized 2 B (header len 2, payload len 0)
   001647 [ts=12867132us, mod=7 level=1 ]coap_send_message(): (2) 
   001647 [ts=12867132us, mod=7 level=0 ]oc_buffer_tx: GATT procedure initiated: notify; att_handle=14
   001647 [ts=12867132us, mod=4 level=0 ]host tx hci data; handle=1 length=9
   001647 [ts=12867132us, mod=4 level=0 ]ble_hs_hci_acl_tx(): 0x01 0x00 0x09 0x00 0x05 0x00 0x04 0x00 0x1b 0x0e 0x00 0x00 0xa3 
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org