You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "hjr265 (via GitHub)" <gi...@apache.org> on 2023/07/12 19:03:29 UTC
[GitHub] [beam] hjr265 opened a new pull request, #27477: Fix BigQuery batch insertion loop; fixes #27476
hjr265 opened a new pull request, #27477:
URL: https://github.com/apache/beam/pull/27477
The `writeFn` implementation in the `bigqueryio` package (part of the Go SDK) may lose rows when attempting to insert a large amount of data.
https://github.com/apache/beam/blob/843e7fdb239e0a61b47e39ce635c37221cd09f4e/sdks/go/pkg/beam/io/bigqueryio/bigquery.go#L328-L344
The loop iterates over the elements of the given PCollection. For each `val` it encounters it either puts the current batch into BigQuery or appends `val` to the current batch. If `val` is about to make the current batch go over BigQuery's limitations, the batch is put into BigQuery. But, the `val` is then not included in the next batch.
Here is a simplified example: https://play.golang.com/p/_3Enne857Rh vs https://play.golang.com/p/-OaX3HpPZkd. Notice that with the first code "f" is missed. But in the second code "f" is included in the second batch.
This PR moves the contents of the `else` block outside of the conditional flow. When a batch is put into BigQuery, the accumulators are reset (marking the start of a new batch) and then immediately `val` is included in the new batch.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27477: [#27476] Fix BigQuery batch insertion loop
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27477:
URL: https://github.com/apache/beam/pull/27477#issuecomment-1633280784
Obligatory mention that the recommended Beam approach for interacting with is to use the Cross Language IO (in xlang/bigqueryio (or thereaboouts)) that uses the production hardended Java biqgueryio. It's not a drop in replacement however, and requires a portable runner.
The Go SDK is going to have a built in portable runner as the default as of 2.50, but depending on how much work I can get done, it may or may not be able to execute Cross Language Transforms yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27477: Fix BigQuery batch insertion loop
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27477:
URL: https://github.com/apache/beam/pull/27477#issuecomment-1633099751
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @lostluck for label go.
R: @pabloem for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #27477: [#27476] Fix BigQuery batch insertion loop
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #27477:
URL: https://github.com/apache/beam/pull/27477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] hjr265 commented on pull request #27477: Fix BigQuery batch insertion loop
Posted by "hjr265 (via GitHub)" <gi...@apache.org>.
hjr265 commented on PR #27477:
URL: https://github.com/apache/beam/pull/27477#issuecomment-1633059429
Fixes #27476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27477: [#27476] Fix BigQuery batch insertion loop
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27477:
URL: https://github.com/apache/beam/pull/27477#issuecomment-1633283407
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27477?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27477](https://app.codecov.io/gh/apache/beam/pull/27477?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b5ce553) into [master](https://app.codecov.io/gh/apache/beam/commit/843e7fdb239e0a61b47e39ce635c37221cd09f4e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (843e7fd) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #27477 +/- ##
=======================================
Coverage 71.22% 71.22%
=======================================
Files 862 862
Lines 104674 104672 -2
=======================================
Hits 74553 74553
+ Misses 28573 28571 -2
Partials 1548 1548
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `53.67% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/beam/pull/27477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/io/bigqueryio/bigquery.go](https://app.codecov.io/gh/apache/beam/pull/27477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9iaWdxdWVyeWlvL2JpZ3F1ZXJ5Lmdv) | `9.37% <0.00%> (+0.09%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org