You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/05/26 06:18:24 UTC
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #906: [#590][part-1] ManagedBuffer instead ByteBuf to hold ShuffleData
codecov-commenter commented on PR #906:
URL: https://github.com/apache/incubator-uniffle/pull/906#issuecomment-1563863762
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#906](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (db4a0e4) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/9c62784f0115898a6f476ac58ac9a56dc8c915c3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9c62784) will **increase** coverage by `1.71%`.
> The diff coverage is `22.97%`.
```diff
@@ Coverage Diff @@
## master #906 +/- ##
============================================
+ Coverage 55.22% 56.94% +1.71%
- Complexity 2197 2207 +10
============================================
Files 333 316 -17
Lines 16444 14141 -2303
Branches 1306 1312 +6
============================================
- Hits 9081 8052 -1029
+ Misses 6851 5646 -1205
+ Partials 512 443 -69
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/uniffle/common/netty/MessageEncoder.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9NZXNzYWdlRW5jb2Rlci5qYXZh) | `68.75% <0.00%> (-9.83%)` | :arrow_down: |
| [.../common/netty/buffer/FileSegmentManagedBuffer.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9idWZmZXIvRmlsZVNlZ21lbnRNYW5hZ2VkQnVmZmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...client/impl/grpc/ShuffleServerGrpcNettyClient.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL2dycGMvU2h1ZmZsZVNlcnZlckdycGNOZXR0eUNsaWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...niffle/server/netty/ShuffleServerNettyHandler.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9uZXR0eS9TaHVmZmxlU2VydmVyTmV0dHlIYW5kbGVyLmphdmE=) | `1.68% <0.00%> (ø)` | |
| [...a/org/apache/uniffle/common/ShuffleDataResult.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TaHVmZmxlRGF0YVJlc3VsdC5qYXZh) | `35.71% <7.14%> (-7.77%)` | :arrow_down: |
| [...on/netty/protocol/GetLocalShuffleDataResponse.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9wcm90b2NvbC9HZXRMb2NhbFNodWZmbGVEYXRhUmVzcG9uc2UuamF2YQ==) | `66.66% <54.54%> (-7.02%)` | :arrow_down: |
| [...che/uniffle/common/netty/buffer/ManagedBuffer.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9idWZmZXIvTWFuYWdlZEJ1ZmZlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...niffle/common/netty/buffer/NettyManagedBuffer.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9idWZmZXIvTmV0dHlNYW5hZ2VkQnVmZmVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
... and [46 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/906/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org