You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "sullis (via GitHub)" <gi...@apache.org> on 2024/05/07 20:25:36 UTC
[PR] ORC-1710: [Java] reduce enum array allocation [orc]
sullis opened a new pull request, #1926:
URL: https://github.com/apache/orc/pull/1926
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
reduce Java enum array allocation by caching the result of .values() method.
Reference:
https://www.gamlor.info/wordpress/2017/08/javas-enum-values-hidden-allocations/
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This change reduces the number of object allocations.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
GitHub Actions.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1710: [Java] reduce enum array allocation [orc]
Posted by "sullis (via GitHub)" <gi...@apache.org>.
sullis commented on PR #1926:
URL: https://github.com/apache/orc/pull/1926#issuecomment-2101329214
ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1710: [Java] Reduce enum array allocation [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1926:
URL: https://github.com/apache/orc/pull/1926#issuecomment-2101861373
cc @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1710: [Java] Reduce enum array allocation [orc]
Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun commented on PR #1926:
URL: https://github.com/apache/orc/pull/1926#issuecomment-2103980692
Welcome to the Apache ORC community, @sullis !
I have added you to the Apache ORC contributor group and assigned ORC-1710 to you.
Congratulations on your first commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1710: [Java] reduce enum array allocation [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1926:
URL: https://github.com/apache/orc/pull/1926#issuecomment-2101861058
BTW, just a question, are these all instances, @sullis ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1710: [Java] Reduce enum array allocation [orc]
Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun closed pull request #1926: ORC-1710: [Java] Reduce enum array allocation
URL: https://github.com/apache/orc/pull/1926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1710: [Java] Reduce enum array allocation [orc]
Posted by "sullis (via GitHub)" <gi...@apache.org>.
sullis commented on PR #1926:
URL: https://github.com/apache/orc/pull/1926#issuecomment-2101875917
> BTW, just a question, are these all instances, @sullis ?
yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org