You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "zhtaoxiang (via GitHub)" <gi...@apache.org> on 2023/08/31 04:54:12 UTC
[GitHub] [pinot] zhtaoxiang opened a new pull request, #11467: sql between function should be inclusive
zhtaoxiang opened a new pull request, #11467:
URL: https://github.com/apache/pinot/pull/11467
The sql between function should be inclusive. See https://www.w3schools.com/sql/sql_between.asp for an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11467: sql between function should be inclusive
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #11467:
URL: https://github.com/apache/pinot/pull/11467#discussion_r1311178944
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ComparisonFunctions.java:
##########
@@ -61,6 +61,6 @@ public static boolean equals(double a, double b) {
@ScalarFunction
public static boolean between(double val, double a, double b) {
- return val > a && val < b;
+ return val >= a && val <= b;
Review Comment:
I think it's not used in normal filter workflow, but in intermediate stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #11467: sql between function should be inclusive
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11467:
URL: https://github.com/apache/pinot/pull/11467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11467: sql between function should be inclusive
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11467:
URL: https://github.com/apache/pinot/pull/11467#issuecomment-1700395981
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11467?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11467](https://app.codecov.io/gh/apache/pinot/pull/11467?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ea4e06e) into [master](https://app.codecov.io/gh/apache/pinot/commit/f14700a1e2d7ba463ef1c4afb0d7ef2366e1c4f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f14700a) will **decrease** coverage by `48.49%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #11467 +/- ##
=============================================
- Coverage 62.92% 14.43% -48.49%
+ Complexity 1108 201 -907
=============================================
Files 2318 2318
Lines 124328 124326 -2
Branches 18980 18980
=============================================
- Hits 78234 17948 -60286
- Misses 40539 104860 +64321
+ Partials 5555 1518 -4037
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.43% <0.00%> (-48.48%)` | :arrow_down: |
| [java-17](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-20](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.43% <0.00%> (-48.49%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.43% <0.00%> (-48.49%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/11467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.43% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ot/common/function/scalar/ComparisonFunctions.java](https://app.codecov.io/gh/apache/pinot/pull/11467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0NvbXBhcmlzb25GdW5jdGlvbnMuamF2YQ==) | `0.00% <0.00%> (-28.58%)` | :arrow_down: |
... and [1486 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] gortiz commented on a diff in pull request #11467: sql between function should be inclusive
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #11467:
URL: https://github.com/apache/pinot/pull/11467#discussion_r1311152875
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ComparisonFunctions.java:
##########
@@ -61,6 +61,6 @@ public static boolean equals(double a, double b) {
@ScalarFunction
public static boolean between(double val, double a, double b) {
- return val > a && val < b;
+ return val >= a && val <= b;
Review Comment:
Strange that we didn't have a test before. Could you add one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org