You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Werner Punz (Jira)" <de...@myfaces.apache.org> on 2022/12/21 08:32:00 UTC

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

    [ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650314#comment-17650314 ] 

Werner Punz edited comment on MYFACES-4533 at 12/21/22 8:31 AM:
----------------------------------------------------------------

The test maybe wrong here... prefixing the name might not even be needed and raises some issues maybe on the java side.

Also no prefix is needed if you are not in a naming container scenario.

I dont think the name in the viewstate should be prefixed at all, unless there is something in the spec clearly stating that.

The JSDoc clearly does not want a prefix for the ajax xhr post case)

(see comments on the pull request: [https://github.com/apache/myfaces/pull/435])


was (Author: werpu):
The test maybe wrong here... prefixing the name might not even be needed and raises some issues maybe on the java side.

I dont think the name in the viewstate should be prefixed at all, unless there is something in the spec clearly stating that.

The JSDoc clearly does not want a prefix for the ajax xhr post case)

(see comments on the pull request: https://github.com/apache/myfaces/pull/435)

> TCK: Spec 790:  Viewstate input element's name attribute should be prefixed with naming container id 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-4533
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4533
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 4.0.0-RC2
>            Reporter: Volodymyr Siedlecki
>            Priority: Major
>         Attachments: namespacedView.war
>
>
> Failing Line: https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/test/java/ee/jakarta/tck/faces/test/javaee8/namespacedView/Spec790WithNamespacedViewIT.java#L15 5
> Generated Viewstate: 
> {code:java}
> <input type="hidden" name="jakarta.faces.ViewState" id="j_id__v_0:jakarta.faces.ViewState:1" value="NzVhMDlkOGYwNjY1ZWZkODAwMDAwMDAy" autocomplete="off">
> {code}
> The test expects the name attribute to be prefixed with `j_id__v_0`.  My understanding is this should only apply when the view root is an instance of a NamingContainer.   
> The test app's faces-config has the following configuration: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/main/webapp/WEB-INF/faces-config.xml#L25-L28



--
This message was sent by Atlassian Jira
(v8.20.10#820010)