You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2012/12/11 10:15:56 UTC
Re: git commit: corrected javadoc and use unicode escape in Java source
On Tue, Dec 11, 2012 at 10:11 AM, <sv...@apache.org> wrote:
> Updated Branches:
> refs/heads/master 4e308198c -> a83adcd7c
>
>
> corrected javadoc and use unicode escape in Java source
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/a83adcd7
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/a83adcd7
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/a83adcd7
>
> Branch: refs/heads/master
> Commit: a83adcd7c18457b8a86a4d82274d2d4d1d4c3d1e
> Parents: 4e30819
> Author: svenmeier <sv...@apache.org>
> Authored: Tue Dec 11 10:11:26 2012 +0100
> Committer: svenmeier <sv...@apache.org>
> Committed: Tue Dec 11 10:11:26 2012 +0100
>
> ----------------------------------------------------------------------
> .../wicket/resource/PageWithUTF8Properties.java | 4 ++--
> .../UtfPropertiesFilePropertiesLoaderTest.java | 3 +--
> 2 files changed, 3 insertions(+), 4 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/a83adcd7/wicket-core/src/test/java/org/apache/wicket/resource/PageWithUTF8Properties.java
> ----------------------------------------------------------------------
> diff --git
> a/wicket-core/src/test/java/org/apache/wicket/resource/PageWithUTF8Properties.java
> b/wicket-core/src/test/java/org/apache/wicket/resource/PageWithUTF8Properties.java
> index 3491f8c..3a41412 100644
> ---
> a/wicket-core/src/test/java/org/apache/wicket/resource/PageWithUTF8Properties.java
> +++
> b/wicket-core/src/test/java/org/apache/wicket/resource/PageWithUTF8Properties.java
> @@ -21,7 +21,7 @@ import static org.junit.Assert.assertEquals;
> import org.apache.wicket.util.tester.DummyHomePage;
>
> /**
> - * Test page for WICKET-2035
> + * Test page for UtfPropertiesFilePropertiesLoader.
> */
> public class PageWithUTF8Properties extends DummyHomePage
> {
> @@ -31,6 +31,6 @@ public class PageWithUTF8Properties extends DummyHomePage
> public PageWithUTF8Properties()
> {
>
> String actual = getString("testProperty");
> - assertEquals("encöding", actual);
> + assertEquals("enc\u00f6ding", actual);
>
Why this change is needed ?
A problem with platform encoding where the tests run?
> }
> }
> \ No newline at end of file
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/a83adcd7/wicket-core/src/test/java/org/apache/wicket/resource/UtfPropertiesFilePropertiesLoaderTest.java
> ----------------------------------------------------------------------
> diff --git
> a/wicket-core/src/test/java/org/apache/wicket/resource/UtfPropertiesFilePropertiesLoaderTest.java
> b/wicket-core/src/test/java/org/apache/wicket/resource/UtfPropertiesFilePropertiesLoaderTest.java
> index 87d5735..c308915 100644
> ---
> a/wicket-core/src/test/java/org/apache/wicket/resource/UtfPropertiesFilePropertiesLoaderTest.java
> +++
> b/wicket-core/src/test/java/org/apache/wicket/resource/UtfPropertiesFilePropertiesLoaderTest.java
> @@ -21,8 +21,7 @@ import org.apache.wicket.WicketTestCase;
> import org.junit.Test;
>
> /**
> - * WICKET-2035 Change naming convention for xml properties files to
> *.properties.xml instead of
> - * *.xml
> + * Test {@link UtfPropertiesFilePropertiesLoader}.
> */
> public class UtfPropertiesFilePropertiesLoaderTest extends WicketTestCase
> {
>
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com <http://jweekend.com/>
Re: git commit: corrected javadoc and use unicode escape in Java
source
Posted by Sven Meier <sv...@meiers.net>.
>- assertEquals("encöding", actual);
>+ assertEquals("enc\u00f6ding", actual);
>
>Why this change is needed ?
>A problem with platform encoding where the tests run?
I don't think it is really needed. But I know a company where the encoding of all Java sources is switched globally to UTF-8.
So better be safe than sorry.
Sven
On 12/11/2012 10:15 AM, Martin Grigorov wrote:
> On Tue, Dec 11, 2012 at 10:11 AM, <sv...@apache.org> wrote:
>
>> Updated Branches:
>> refs/heads/master 4e308198c -> a83adcd7c
>>
>>
>> corrected javadoc and use unicode escape in Java source
>>
>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/a83adcd7
>> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/a83adcd7
>> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/a83adcd7
>>
>> Branch: refs/heads/master
>> Commit: a83adcd7c18457b8a86a4d82274d2d4d1d4c3d1e
>> Parents: 4e30819
>> Author: svenmeier <sv...@apache.org>
>> Authored: Tue Dec 11 10:11:26 2012 +0100
>> Committer: svenmeier <sv...@apache.org>
>> Committed: Tue Dec 11 10:11:26 2012 +0100
>>
>> ----------------------------------------------------------------------
>> .../wicket/resource/PageWithUTF8Properties.java | 4 ++--
>> .../UtfPropertiesFilePropertiesLoaderTest.java | 3 +--
>> 2 files changed, 3 insertions(+), 4 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/wicket/blob/a83adcd7/wicket-core/src/test/java/org/apache/wicket/resource/PageWithUTF8Properties.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/wicket-core/src/test/java/org/apache/wicket/resource/PageWithUTF8Properties.java
>> b/wicket-core/src/test/java/org/apache/wicket/resource/PageWithUTF8Properties.java
>> index 3491f8c..3a41412 100644
>> ---
>> a/wicket-core/src/test/java/org/apache/wicket/resource/PageWithUTF8Properties.java
>> +++
>> b/wicket-core/src/test/java/org/apache/wicket/resource/PageWithUTF8Properties.java
>> @@ -21,7 +21,7 @@ import static org.junit.Assert.assertEquals;
>> import org.apache.wicket.util.tester.DummyHomePage;
>>
>> /**
>> - * Test page for WICKET-2035
>> + * Test page for UtfPropertiesFilePropertiesLoader.
>> */
>> public class PageWithUTF8Properties extends DummyHomePage
>> {
>> @@ -31,6 +31,6 @@ public class PageWithUTF8Properties extends DummyHomePage
>> public PageWithUTF8Properties()
>> {
>>
>
>> String actual = getString("testProperty");
>> - assertEquals("encöding", actual);
>> + assertEquals("enc\u00f6ding", actual);
>>
> Why this change is needed ?
> A problem with platform encoding where the tests run?
>
>
>> }
>> }
>> \ No newline at end of file
>>
>>
>> http://git-wip-us.apache.org/repos/asf/wicket/blob/a83adcd7/wicket-core/src/test/java/org/apache/wicket/resource/UtfPropertiesFilePropertiesLoaderTest.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/wicket-core/src/test/java/org/apache/wicket/resource/UtfPropertiesFilePropertiesLoaderTest.java
>> b/wicket-core/src/test/java/org/apache/wicket/resource/UtfPropertiesFilePropertiesLoaderTest.java
>> index 87d5735..c308915 100644
>> ---
>> a/wicket-core/src/test/java/org/apache/wicket/resource/UtfPropertiesFilePropertiesLoaderTest.java
>> +++
>> b/wicket-core/src/test/java/org/apache/wicket/resource/UtfPropertiesFilePropertiesLoaderTest.java
>> @@ -21,8 +21,7 @@ import org.apache.wicket.WicketTestCase;
>> import org.junit.Test;
>>
>> /**
>> - * WICKET-2035 Change naming convention for xml properties files to
>> *.properties.xml instead of
>> - * *.xml
>> + * Test {@link UtfPropertiesFilePropertiesLoader}.
>> */
>> public class UtfPropertiesFilePropertiesLoaderTest extends WicketTestCase
>> {
>>
>>
>