You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/20 20:41:51 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27658:
[SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
MaxGekk opened a new pull request #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658
### What changes were proposed in this pull request?
In the PR, I propose to add the `legacySizeOfNull ` parameter to the `Size` expression, and pass the value of `spark.sql.legacy.sizeOfNull` if `legacySizeOfNull` is not provided on creation of `Size`.
### Why are the changes needed?
This allows to avoid the issue when the configuration change between different phases of planning, and this can silently break a query plan which can lead to crashes or data corruption.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
By `CollectionExpressionsSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27658:
[SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589299503
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27658: [SPARK-30894][SQL] Make
Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589299044
**[Test build #118734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118734/testReport)** for PR 27658 at commit [`f768958`](https://github.com/apache/spark/commit/f7689581e2e7b87660a12042a10f9e23bd9346f0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27658: [SPARK-30894][SQL]
Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589534103
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27658: [SPARK-30894][SQL]
Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589299512
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23485/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27658: [SPARK-30894][SQL] Make
Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589444391
**[Test build #118734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118734/testReport)** for PR 27658 at commit [`f768958`](https://github.com/apache/spark/commit/f7689581e2e7b87660a12042a10f9e23bd9346f0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class Size(child: Expression, legacySizeOfNull: Boolean)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27658: [SPARK-30894][SQL]
Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589299503
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27658: [SPARK-30894][SQL] Make
Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589302575
See https://github.com/apache/spark/pull/27628#discussion_r381246285
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27658:
[SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589444779
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27658:
[SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589299512
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23485/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27658: [SPARK-30894][SQL]
Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589444782
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118734/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27658: [SPARK-30894][SQL]
Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27658:
[SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589444782
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118734/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27658: [SPARK-30894][SQL]
Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589444779
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27658:
[SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27658: [SPARK-30894][SQL] Make Size's nullable independent from SQL config changes
URL: https://github.com/apache/spark/pull/27658#issuecomment-589299044
**[Test build #118734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118734/testReport)** for PR 27658 at commit [`f768958`](https://github.com/apache/spark/commit/f7689581e2e7b87660a12042a10f9e23bd9346f0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org