You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/22 15:47:08 UTC
[GitHub] [airflow] potiuk opened a new pull request #18435: Protect agains images not being pulled properly
potiuk opened a new pull request #18435:
URL: https://github.com/apache/airflow/pull/18435
Recently we had a problem that our CI got broken because
pulled images were not tagged properly after #17883 missed image
tagging. This has been fixed in #18433 but the problem is that this
might happen in the future and mignt not get noticed on time.
This PR prevents from similar situations happnening. Whenever we
try to run doc building or tests we set --pull policy to never
for both docker and docker compose which should simply fail if
the images were not pulled and tagged properly rather than
fail over to pulling latest `main` image.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #18435: Protect agains images not being pulled properly
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18435:
URL: https://github.com/apache/airflow/pull/18435#discussion_r714080825
##########
File path: scripts/ci/docker-compose/base.yml
##########
@@ -15,10 +15,11 @@
# specific language governing permissions and limitations
# under the License.
---
-version: "2.2"
+version: "3.7"
Review comment:
I need "3.7" everywhere to get "pull_policy": never (available as of May 2021 in "3.,7".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #18435: Protect agains images not being pulled properly
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18435:
URL: https://github.com/apache/airflow/pull/18435#discussion_r714163657
##########
File path: scripts/ci/docker-compose/backend-mssql-bind-volume.yml
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
---
-version: "2.2"
+version: "3.7"
Review comment:
Deleted. Seems no side effects. Good catch. TIL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18435: Protect agains images not being pulled properly
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18435:
URL: https://github.com/apache/airflow/pull/18435#issuecomment-925297193
Looks good !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #18435: Protect agains images not being pulled properly
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #18435:
URL: https://github.com/apache/airflow/pull/18435#discussion_r714157847
##########
File path: scripts/ci/docker-compose/backend-mssql-bind-volume.yml
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
---
-version: "2.2"
+version: "3.7"
Review comment:
This field is deprecated according to compose-spec. We should delete this field if it causes any unexpected problems. https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-top-level-element
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18435: Protect agains images not being pulled properly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18435:
URL: https://github.com/apache/airflow/pull/18435#issuecomment-925307205
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18435: Protect agains images not being pulled properly
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18435:
URL: https://github.com/apache/airflow/pull/18435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #18435: Protect agains images not being pulled properly
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18435:
URL: https://github.com/apache/airflow/pull/18435#discussion_r714159348
##########
File path: scripts/ci/docker-compose/backend-mssql-bind-volume.yml
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
---
-version: "2.2"
+version: "3.7"
Review comment:
Ah. Interesting Will delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org