You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Wes Wannemacher <we...@wantii.com> on 2008/02/09 23:17:17 UTC
First commit is a FAILURE!
I tried to commit a fix for WW-2477, which would be my first. I didn't
realize that Bamboo is running/building with java 6. Shortly after
committing, the Bamboo builds failed on the unit test I committed with
the fix. I apologize for that :(
I went ahead and deleted the test (the actual fixes were trivial). I
have to go out to eat, but when I get back, I'll re-write the test using
java 6 and commit. I attached the patch that I attempted to commit to
the JIRA (in case anyone wants to take a look and help me guess why it
works in 1.5 but fails when run in 6.0).
Again sorry!
-Wes
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [struts-dev] First commit is a FAILURE!
Posted by Dale Newfield <Da...@Newfield.org>.
Wes Wannemacher wrote:
> my surprise birthday party
Happy Birthday!
-Dale
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: First commit is a FAILURE!
Posted by Wes Wannemacher <we...@wantii.com>.
On Sat, 2008-02-09 at 14:40 -0800, Martin Cooper wrote:
> My guess is that it has nothing to do with the JDK version, but has to do
> with the state of the classpath while the tests are being run. Your test
> code does not handle the case in which your target URL is not found in the
> classpath, and if that happened, it would result in an NPE on the line of
> code that caused an NPE in Bamboo...
>
> --
> Martin Cooper
When I tell maven to use a 6.x series JDK, I get an NPE in the same
spot. I will fail a bit less miserably though if the file/path isn't
found. But, I assumed that the TLD file will be there since Maven builds
it. I didn't try it, but a .getResource() call might find the TLD file
magically, if so, it would significantly decrease the size of the unit
test.
I have to show up to my surprise birthday party my wife doesn't think I
know about in a little bit, so I'll get it taken care of tonight.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: First commit is a FAILURE!
Posted by Martin Cooper <ma...@apache.org>.
On Feb 9, 2008 2:17 PM, Wes Wannemacher <we...@wantii.com> wrote:
> I tried to commit a fix for WW-2477, which would be my first. I didn't
> realize that Bamboo is running/building with java 6. Shortly after
> committing, the Bamboo builds failed on the unit test I committed with
> the fix. I apologize for that :(
>
> I went ahead and deleted the test (the actual fixes were trivial). I
> have to go out to eat, but when I get back, I'll re-write the test using
> java 6 and commit. I attached the patch that I attempted to commit to
> the JIRA (in case anyone wants to take a look and help me guess why it
> works in 1.5 but fails when run in 6.0).
My guess is that it has nothing to do with the JDK version, but has to do
with the state of the classpath while the tests are being run. Your test
code does not handle the case in which your target URL is not found in the
classpath, and if that happened, it would result in an NPE on the line of
code that caused an NPE in Bamboo...
--
Martin Cooper
> Again sorry!
>
> -Wes
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: First commit is a FAILURE! - Second commit is a SUCCESS!
Posted by Martin Cooper <ma...@apache.org>.
On Feb 10, 2008 10:10 AM, Wes Wannemacher <we...@wantii.com> wrote:
> I just updated the unit test and bamboo is happy again. I ended up
> looking for the TLD file using getResource(), which is a lot cleaner
> anyways. I noticed a few things in the process, first you really have to
> persuade eclipse to quit using tabs, and second, I can't assign the JIRA
> to myself (or close it).
That should be fixed now. I've just added you (and Jeromy) to the
struts-developers group in JIRA.
--
Martin Cooper
> I don't know if I should ask for that later, or
> if it's a PMC-only thing. But, if someone gets a chance, go ahead and
> look over WW-2477 and close it for me. Thanks for the help everyone!
>
> -Wes
>
> On Sun, 2008-02-10 at 07:10 -0800, Dave Newton wrote:
> > --- Antonio Petrelli <an...@gmail.com> wrote:
> > > Making mistakes, IMHO, is part of the development process:
> >
> > I must be a really, really good developer then.
> >
> > Dave
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: First commit is a FAILURE! - Second commit is a SUCCESS!
Posted by Wes Wannemacher <we...@wantii.com>.
I just updated the unit test and bamboo is happy again. I ended up
looking for the TLD file using getResource(), which is a lot cleaner
anyways. I noticed a few things in the process, first you really have to
persuade eclipse to quit using tabs, and second, I can't assign the JIRA
to myself (or close it). I don't know if I should ask for that later, or
if it's a PMC-only thing. But, if someone gets a chance, go ahead and
look over WW-2477 and close it for me. Thanks for the help everyone!
-Wes
On Sun, 2008-02-10 at 07:10 -0800, Dave Newton wrote:
> --- Antonio Petrelli <an...@gmail.com> wrote:
> > Making mistakes, IMHO, is part of the development process:
>
> I must be a really, really good developer then.
>
> Dave
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: First commit is a FAILURE!
Posted by Dave Newton <ne...@yahoo.com>.
--- Antonio Petrelli <an...@gmail.com> wrote:
> Making mistakes, IMHO, is part of the development process:
I must be a really, really good developer then.
Dave
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: First commit is a FAILURE!
Posted by Antonio Petrelli <an...@gmail.com>.
2008/2/9, Wes Wannemacher <we...@wantii.com>:
>...I apologize for that :(
>
> Again sorry!
Wes
Don't be too bad with yourself. We all make mistakes, but, luckily, in
our case we have Subversion that helps us returning to the working
versions :-)
Making mistakes, IMHO, is part of the development process: do
something, test if there are errors, correct and so on. Sometimes
errors get committed, but it is not a problem, since the versioning
tool is there to help us.
Ciao
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: First commit is a FAILURE!
Posted by Ted Husted <hu...@apache.org>.
Bamboo is also know to generate false negatives. If it passed locally
under J5, try making an innocuous commit so it builds again.
I don't remember discussed using J6 code for tests or otherwise, and
so if we have a J6 issue, we should address that directly.
HTH, Ted.
On Feb 9, 2008 5:17 PM, Wes Wannemacher <we...@wantii.com> wrote:
> I tried to commit a fix for WW-2477, which would be my first. I didn't
> realize that Bamboo is running/building with java 6. Shortly after
> committing, the Bamboo builds failed on the unit test I committed with
> the fix. I apologize for that :(
>
> I went ahead and deleted the test (the actual fixes were trivial). I
> have to go out to eat, but when I get back, I'll re-write the test using
> java 6 and commit. I attached the patch that I attempted to commit to
> the JIRA (in case anyone wants to take a look and help me guess why it
> works in 1.5 but fails when run in 6.0).
>
> Again sorry!
>
> -Wes
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
HTH, Ted
http://husted.com/ted/blog/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org