You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by eskabetxe <gi...@git.apache.org> on 2018/09/28 19:59:22 UTC
[GitHub] bahir-flink pull request #35: [BAHIR-179] fail silently with docker tests
GitHub user eskabetxe opened a pull request:
https://github.com/apache/bahir-flink/pull/35
[BAHIR-179] fail silently with docker tests
change test to add integration test and avoid this kind test to be launch on local.
This PR (https://github.com/apache/bahir-flink/pull/33) must be merged before
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eskabetxe/bahir-flink BAHIR-179
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir-flink/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit b4039038de8e5d02ed1054ee995cabd050e3b218
Author: Joao Boto <bo...@...>
Date: 2018-08-22T10:10:32Z
BAHIR-114: update flume to 1.8 and add some tests
commit 9c9a9ada2eadfb9e7796eb0e2de6b596697bcc41
Author: Joao Boto <bo...@...>
Date: 2018-09-16T23:47:40Z
BAHIR-114: merge master
commit 80c88e03ee2233dc34376b2526400d5bda33e8d4
Author: Joao Boto <bo...@...>
Date: 2018-09-28T19:37:30Z
BAHIR-179: fail silently docker tests
commit 8dcc7e99f487da183e8c459c3c2abc60405b3251
Author: Joao Boto <bo...@...>
Date: 2018-09-28T19:40:59Z
BAHIR-179: fail silently docker tests
----
---
[GitHub] bahir-flink issue #35: [BAHIR-179] fail silently with docker tests
Posted by eskabetxe <gi...@git.apache.org>.
Github user eskabetxe commented on the issue:
https://github.com/apache/bahir-flink/pull/35
@lresende, @rmetzger
---
[GitHub] bahir-flink issue #35: [BAHIR-179] fail silently with docker tests
Posted by eskabetxe <gi...@git.apache.org>.
Github user eskabetxe commented on the issue:
https://github.com/apache/bahir-flink/pull/35
@lresende
---
[GitHub] bahir-flink issue #35: [BAHIR-179] fail silently with docker tests
Posted by eskabetxe <gi...@git.apache.org>.
Github user eskabetxe commented on the issue:
https://github.com/apache/bahir-flink/pull/35
@lresende updated with master..
---
[GitHub] bahir-flink pull request #35: [BAHIR-179] fail silently with docker tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bahir-flink/pull/35
---
[GitHub] bahir-flink issue #35: [BAHIR-179] fail silently with docker tests
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/35
BTW, I have disabled the failing docker tests in master after applying your last pr #33
---
[GitHub] bahir-flink issue #35: [BAHIR-179] fail silently with docker tests
Posted by eskabetxe <gi...@git.apache.org>.
Github user eskabetxe commented on the issue:
https://github.com/apache/bahir-flink/pull/35
@lresende any change to merge this
---
[GitHub] bahir-flink issue #35: [BAHIR-179] fail silently with docker tests
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/35
@eskabetxe Please rebase your PR. Also, I see a few changes on different projects other than the flume tests from bahir-114 (including disabling tests that are working on current master) that we are trying to address. If these are additional enhancements, please create different prs and smaller ones.
---
[GitHub] bahir-flink issue #35: [BAHIR-179] fail silently with docker tests
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/35
@eskabetxe if you update to latest master and try to rebase this, do you get any conflicts ?
This is what I am getting :
```
First, rewinding head to replay your work on top of it...
Applying: BAHIR-114: update flume to 1.8 and add some tests
Using index info to reconstruct a base tree...
M .travis.yml
M flink-connector-flume/README.md
M flink-connector-flume/pom.xml
M flink-connector-flume/src/main/java/org/apache/flink/streaming/connectors/flume/FlumeSink.java
M pom.xml
Falling back to patching base and 3-way merge...
Auto-merging pom.xml
CONFLICT (content): Merge conflict in pom.xml
Auto-merging flink-connector-flume/src/test/java/org/apache/flink/streaming/connectors/flume/FlumeSinkTest.java
CONFLICT (add/add): Merge conflict in flink-connector-flume/src/test/java/org/apache/flink/streaming/connectors/flume/FlumeSinkTest.java
Auto-merging .travis.yml
CONFLICT (content): Merge conflict in .travis.yml
error: Failed to merge in the changes.
Patch failed at 0001 BAHIR-114: update flume to 1.8 and add some tests
Use 'git am --show-current-patch' to see the failed patch
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
```
---
[GitHub] bahir-flink issue #35: [BAHIR-179] fail silently with docker tests
Posted by eskabetxe <gi...@git.apache.org>.
Github user eskabetxe commented on the issue:
https://github.com/apache/bahir-flink/pull/35
hi @lresende,
the changes are because i change:
- the tests with docker images, this affect the projects of flume and kudu
- upgrade junit to version 5.3.1
- the test disabled, is not working on master, because its ignored because actual parent pom have this
<includes>
<include>**/Test*.java</include>
<include>**/*Test.java</include>
<include>**/*TestCase.java</include>
<include>**/*Suite.java</include>
</includes>
and the test class is named ActiveMQConnectorITCase and its not working, if you launch the test on local you will see that fail..
---
[GitHub] bahir-flink issue #35: [BAHIR-179] fail silently with docker tests
Posted by eskabetxe <gi...@git.apache.org>.
Github user eskabetxe commented on the issue:
https://github.com/apache/bahir-flink/pull/35
@lresende could you merge this
---
[GitHub] bahir-flink issue #35: [BAHIR-179] fail silently with docker tests
Posted by eskabetxe <gi...@git.apache.org>.
Github user eskabetxe commented on the issue:
https://github.com/apache/bahir-flink/pull/35
@lresende i change the commits to be one by project and be more easy to see the changes
all the changes are related by the upgrade of junit version, but if you still prefer a distinct PR for every change i could do it.
---