You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "DanielCarter-stack (via GitHub)" <gi...@apache.org> on 2026/08/11 13:12:47 UTC
[PR] [Docs][Connector-V2] Improve ClickhouseFile Cloudberry Jira Persistiq and SelectDB-Cloud connector docs [seatunnel]
DanielCarter-stack opened a new pull request, #11767:
URL: https://github.com/apache/seatunnel/pull/11767
## What Problem Does This PR Solve?
Five V2 connector doc pages were inconsistent with the rest of the connector doc set: missing Support Those Engines headers, options tables without a description column, broken or undocumented option keys, and only one runnable example each. This PR brings all ten files (docs/en + docs/zh) up to the same structural standard as the recently-merged connector doc PRs.
### ClickhouseFile (sink)
- Add the missing Support Those Engines header and a description column on the options table.
- Correct the clickhouse_local_path description: the binary is needed on every worker (Spark executor, Flink TaskManager, Zeta worker), not just the driver.
- Add a How it works section that explains why the connector cannot offer exactly-once and what to use instead.
- Add four examples (minimal BATCH, multi-shard password-less SSH, SSH key auth, STREAMING with checkpoint).
### Cloudberry (source)
- Replace the previous key options bullet list with a complete options table aligned to the actual JDBC source option keys.
- Call out partition_lower_bound / partition_upper_bound as the recommended pattern for large parallel scans.
- Add a streaming-poll example and a CDC workaround note.
### Jira (source)
- Add the missing Support Those Engines header.
- Add a paginated-read example using cursor-based paging config.
- Add a POST-with-JQL example that demonstrates content_field.
- Clarify that the auto-generated Authorization header must not be duplicated in headers.
### Persistiq (source)
- Fix the option-name typo: the docs referred to content_json in the option table, but the connector actually exposes content_field. All examples were already using content_field.
- Correct the documented format default from json to TEXT.
- Add the missing paging, connect_timeout_ms, socket_timeout_ms, enable_multi_lines, and json_filed_missed_return_null options.
- Add a paginated json_field example and a STREAMING poll example.
### SelectDB Cloud (sink)
- Document two options that exist in the source but were not in the docs: sink.label-prefix and sink.flush.queue-size.
- Add a How CDC works section explaining the three prerequisites for CDC ingest: Unique model + batch delete enabled + sink.enable-delete=true.
- Add a STREAMING-with-checkpoint example, a CDC-from-MySQL-CDC example, and a 2PC timeout example.
## Validation
- 10 files changed, 1406 insertions, 220 deletions.
- All code fences remain balanced.
- All HOCON examples use only option keys that exist in the connector source code (cross-checked against ClickhouseFileSinkOptions.java, SelectDBSinkOptions.java, and HttpSourceOptions.java).
## Notes
- No support-version rows were added.
- No connectors touched in the last 7 days (by either merged or open PRs) were modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Docs][Connector-V2] Improve ClickhouseFile Cloudberry Jira Persistiq and SelectDB-Cloud connector docs [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11767:
URL: https://github.com/apache/seatunnel/pull/11767#issuecomment-6412418028
The follow-up now documents the concrete Jira/Persistiq readers as reading one HTTP response, without advertising unsupported automatic pagination. Both book examples use a matching illustrative mock endpoint; the real Persistiq users example remains separate. ClickhouseFile examples now supply the list/password fields that its current factory always parses. SelectDB mapping, config-block and label descriptions were corrected in both languages.
The eight-document correction passed scoped Spotless and independent source review. Current-head CI and the repository approval gate remain separate; no connector runtime changes were made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Docs][Connector-V2] Improve ClickhouseFile Cloudberry Jira Persistiq and SelectDB-Cloud connector docs [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11767:
URL: https://github.com/apache/seatunnel/pull/11767#issuecomment-6473911825
Thanks for the contribution. The merge-gate fact cited in my previous conclusion has changed: GitHub now reports a real merge conflict. This follow-up corrects that gate on the unchanged reviewed head; it is not another full source review or a sync request based only on being behind.
Gate snapshot (2026-10-28T15:58:33+00:00), head `d1b3cf5a29460ceabbf30af8229df1397d139d50`: [Build](https://github.com/apache/seatunnel/runs/121695762002) is `ACTION_REQUIRED`.
The exact blocking stage is **Build workflow-run detection**: the check says no fork Build was found for this SHA. This is not an executed test failure and does not by itself prove that fork Actions is disabled. Open the fork Actions tab, enable workflows if needed, then manually run the existing Build workflow for this PR branch. If a matching run already exists, link it for a maintainer to reconcile the aggregate. No empty commit or speculative dependency change is requested.
Upstream check: current dev retains the fork-run adoption workflow and its scheduled/manual status-refresh path. A base sync alone cannot enable fork Actions or supply a missing exact-head workflow run, so I am not prescribing sync as the fix for this activation gate.
My [previous source conclusion](https://github.com/apache/seatunnel/pull/11767#pullrequestreview-5651245346) remains clear for the reviewed scope. CI is not being passed by inference, and this follow-up is not an effective approval.
Separately, GitHub reports merge conflicts with `dev`. Please sync the latest base and resolve the conflicts first; the resulting new head needs checks and re-review. This conflict gate is independent of CI and existing source findings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Docs][Connector-V2] Improve ClickhouseFile Cloudberry Jira Persistiq and SelectDB-Cloud connector docs [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11767:
URL: https://github.com/apache/seatunnel/pull/11767#issuecomment-6393792577
Resolved the six documentation conflicts against current `dev` and pushed the corrections in `8f544b8fa825`. The final PR remains limited to the same ten connector documentation files.
The source-checked corrections cover real JDBC split option names/defaults and MIN/MAX bounds; bounded Cloudberry reads; Persistiq `x-api-key` authentication, line parsing, pagination limits and recovery/repeated-row behavior; generated Jira authorization precedence and the current Cloud `/search/jql` cursor endpoint; SelectDB delete markers and buffer size; and ClickhouseFile commit preparation/ATTACH PART behavior. English/Chinese documentation and existing changelog sections are preserved.
Spotless and the owned diff whitespace check passed, and an independent maintainer checked the complete final documentation change. New-head GitHub CI still needs to complete; these checks do not claim authenticated SaaS or database runtime acceptance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org