You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/01 02:21:54 UTC
[GitHub] [arrow] WillAyd opened a new pull request, #14555: ARROW-18098 [C++] Vector kernel for "intersecting" two arrays
WillAyd opened a new pull request, #14555:
URL: https://github.com/apache/arrow/pull/14555
@jorisvandenbossche
I've commented out a few things that aren't working, which I'd summarize as:
1. Null Handling - by default numpy's intersect1d discards NaN, but here NULL would be returned. Its worth discussing whether we want NULL to be included here or not; I _think_ we should and give the user the ability to control where it appears via SortOptions
2. Boolean Type - had issues with the call to Buffer::Wrap complaining that the `const` qualifer on the vector was being discarded. Didn't fully troubleshoot this, but wasn't sure an intersect on BooleanTypes is all that useful either
3. Temporal Types - got a segfault that I need to trouble shoot.
There likely is a better way of constructing the result that could naturally solve issues 2 and 3 above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] WillAyd closed pull request #14555: ARROW-18098 [C++] Vector kernel for "intersecting" two arrays
Posted by GitBox <gi...@apache.org>.
WillAyd closed pull request #14555: ARROW-18098 [C++] Vector kernel for "intersecting" two arrays
URL: https://github.com/apache/arrow/pull/14555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14555: ARROW-18098 [C++] Vector kernel for "intersecting" two arrays
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14555:
URL: https://github.com/apache/arrow/pull/14555#issuecomment-1297933497
https://issues.apache.org/jira/browse/ARROW-18098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] WillAyd commented on pull request #14555: ARROW-18098 [C++] Vector kernel for "intersecting" two arrays
Posted by GitBox <gi...@apache.org>.
WillAyd commented on PR #14555:
URL: https://github.com/apache/arrow/pull/14555#issuecomment-1320331120
Putting aside for now - will come back later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org