[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #849: GUACAMOLE-926: Batch Import: Attempt to correct incorrectly-cased parameter values if possible

["mike-jumper (via GitHub)" <gi...@apache.org>]

mike-jumper commented on code in PR #849:
URL: https://github.com/apache/guacamole-client/pull/849#discussion_r1184071222


##########
guacamole/src/main/frontend/src/app/import/services/connectionParseService.js:
##########
@@ -359,81 +369,132 @@ angular.module('import').factory('connectionParseService',
     }
 
     /**
-     * Returns a promise that resolves to a map of all valid protocols to the
-     * boolean value "true", i.e. a set of all valid protocols.
+     * Returns a promise that resolves to a map of all valid protocols to a map
+     * of connection parameter names to a map of lower-cased and trimmed option
+     * values for that parameter to the actual valid option value.
+     *
+     * This format is designed for easy retrieval of corrected paramter values

Review Comment:
   parameter*



##########
guacamole/src/main/frontend/src/app/import/services/connectionParseService.js:
##########
@@ -200,7 +200,8 @@ angular.module('import').factory('connectionParseService',
     /**
      * Returns a promise that will resolve to a transformer function that will
      * perform various checks and transforms relating to the connection group
-     * tree heirarchy. It will:
+     * tree heirarchy, pushing any errors into the resolved connection object.

Review Comment:
   hierarchy*



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org