[GitHub] [cordova-electron] erisu commented on issue #185: Specify electron version to use

[GitBox <gi...@apache.org>]

erisu commented on issue #185:
URL: https://github.com/apache/cordova-electron/issues/185#issuecomment-758436168


   This request has been mentioned a few times but it is a bit challenging.
   
   There are two places where the version is defined. 
   The `package.json` of the platform. This dependency is used for the `cordova run` command. Currently, the pinning contains `^` which accepts new minor and patches. This `^` is problematic and should be hard pin to follow the second location. The reason it is problematic is that the run command may eventually fail which no changes to the user's project.
   The `build.json` is hard pinned. This is used for building the packages. Because it is hard pinned, it is consistent and should not fail unexpectedly if there is no change to the project. This is used in the `cordova build` command.
   If we allow the users to specify a version, we can not guarantee that the project will build or run successfully. Nor can we provide speedy support.
   
   Something could be implemented for experimental purposes, but reported issue tickets of unsupported dependencies may get closed immediately or thrown in a backlog which might over time get forgotten. Also with changes to Electron, there might be changes required for the builder.
   
   I had taken a look into potentially using a post-install script to manage to install the targeted version during platform add but the post-install script was not being executed as expected.
   
   Shortly, I will be changing the pinning in `package.json` to be hard pinned to resolve the current issue where the `cordova run` outcome might not match with `cordova build`, but whatever solution you had in mind needs to support both run and build and also how to resolve builder dependency matching with the electron version they wanted.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org