You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/12 12:37:05 UTC
[GitHub] [rocketmq] xyjForCoding opened a new pull request, #4295: [ISSUE #4287]add detail descriptions to readme
xyjForCoding opened a new pull request, #4295:
URL: https://github.com/apache/rocketmq/pull/4295
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4295: [ISSUE #4287]add detail descriptions to readme
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4295:
URL: https://github.com/apache/rocketmq/pull/4295#issuecomment-1126276964
[](https://coveralls.io/builds/49108889)
Coverage increased (+0.2%) to 52.211% when pulling **6ea94e242401d1295683b30c70aaed1d7fd54855 on xyjForCoding:develop** into **fd484ae6d9a31c686fef6c18af9de443e02d09e3 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] caigy merged pull request #4295: [ISSUE #4287]add detail descriptions to readme
Posted by GitBox <gi...@apache.org>.
caigy merged PR #4295:
URL: https://github.com/apache/rocketmq/pull/4295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] caigy commented on a diff in pull request #4295: [ISSUE #4287]add detail descriptions to readme
Posted by GitBox <gi...@apache.org>.
caigy commented on code in PR #4295:
URL: https://github.com/apache/rocketmq/pull/4295#discussion_r871976119
##########
broker/src/main/java/org/apache/rocketmq/broker/plugin/MessageStoreFactory.java:
##########
@@ -22,7 +22,7 @@
import org.apache.rocketmq.store.MessageStore;
public final class MessageStoreFactory {
- public final static MessageStore build(MessageStorePluginContext context, MessageStore messageStore)
+ public static MessageStore build(MessageStorePluginContext context, MessageStore messageStore)
Review Comment:
It seems this change has nothing to do with the issue, you may open another issue to change it.
##########
README.md:
##########
@@ -41,8 +41,8 @@ It offers a variety of features:
* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go)
* [RocketMQ Client Python](https://github.com/apache/rocketmq-client-python)
* [RocketMQ Client Nodejs](https://github.com/apache/rocketmq-client-nodejs)
-* [RocketMQ Spring](https://github.com/apache/rocketmq-spring)
-* [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter)
+* [RocketMQ Spring](https://github.com/apache/rocketmq-spring): The integration component of RocketMQ and spring framework
Review Comment:
1. 'spring' should be 'Spring'.
2. Accurately rocketmq-spring is starter of Spring Boot, not integration to Spring Framework itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] caigy commented on a diff in pull request #4295: [ISSUE #4287]add detail descriptions to readme
Posted by GitBox <gi...@apache.org>.
caigy commented on code in PR #4295:
URL: https://github.com/apache/rocketmq/pull/4295#discussion_r873278656
##########
README.md:
##########
@@ -41,8 +41,8 @@ It offers a variety of features:
* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go)
* [RocketMQ Client Python](https://github.com/apache/rocketmq-client-python)
* [RocketMQ Client Nodejs](https://github.com/apache/rocketmq-client-nodejs)
-* [RocketMQ Spring](https://github.com/apache/rocketmq-spring)
-* [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter)
+* [RocketMQ Spring](https://github.com/apache/rocketmq-spring): A project which helps developers quickly integrate RpcketMQ with Spring Boot
Review Comment:
Please fix typo 'R**p**cketMQ'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org