You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Mercy Ma <me...@apache.org> on 2018/12/20 03:24:38 UTC
Donate dubbo-registry-nacos
Hi, community,
I'd like to donate dubbo-registry-nacos into dubbo and may rename to
*incubator-dubbo-registry-**nacos*, and the source code is
https://github.com/dubbo/dubbo-registry-nacos.
Therefore I am calling a vote:
[ ] +1 Accept the dubbo-registry-nacos into Dubbo
[ ] -1 Do not accept the dubbo-registry-nacos into Dubbo
Kind regards,
Mercy Ma
Re: Donate dubbo-registry-nacos
Posted by Ian Luo <ia...@gmail.com>.
+1 Accept the dubbo-registry-nacos into Dubbo
On Thu, Dec 20, 2018 at 11:24 AM Mercy Ma <me...@apache.org> wrote:
> Hi, community,
>
> I'd like to donate dubbo-registry-nacos into dubbo and may rename to
> *incubator-dubbo-registry-**nacos*, and the source code is
> https://github.com/dubbo/dubbo-registry-nacos.
>
> Therefore I am calling a vote:
>
> [ ] +1 Accept the dubbo-registry-nacos into Dubbo
> [ ] -1 Do not accept the dubbo-registry-nacos into Dubbo
>
> Kind regards,
> Mercy Ma
>
Re: Donate dubbo-registry-nacos
Posted by Ian Luo <ia...@gmail.com>.
+1 to include its impl directly into Apache Dubbo repo from the respective
of easy-maintenance.
If a side project is an Dubbo's extension, it is easy to maintain it to
keep it in Dubbo group when it is immature, but once it's mature enough
(not to hurt the main project), we should move it into Apache Dubbo repo,
instead of moving it Apache group as a separated project since it is easier
to maintain it.
Thanks,
-Ian.
On Tue, Jan 8, 2019 at 5:47 PM Mercy <me...@apache.org> wrote:
> Hi,
>
> I'd like to take the dubbo-registry-nacos as a registry
> implementation and put the source code into dubbo branch 2.6.6+, what's
> your opinion?
>
> Kind regards,
>
> Mercy
>
> 在 2018/12/25 下午5:44, Huxing Zhang 写道:
> > Hi,
> >
> > On Sun, Dec 23, 2018 at 4:48 AM Justin Mclean <ju...@classsoftware.com>
> wrote:
> >> Hi,
> >>
> >>> Yes, both of them are Dubbo ppmc member.cI think we need a software
> grant here, shall we?
> >> Give both people involved have signed ICLAs and the code in Apache
> licensed it’s probably not required. It may depend on who actually owns the
> code (usually the company those people work for but it depends on their
> employment conditions and contract).
> > According to my knowledge, I think the company owns the code. It's
> > better to have a software grant there.
> >
> >> Thanks,
> >> Justin
> >
> >
>
Re: Donate dubbo-registry-nacos
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
On Tue, Jan 8, 2019 at 5:47 PM Mercy <me...@apache.org> wrote:
>
> Hi,
>
> I'd like to take the dubbo-registry-nacos as a registry
> implementation and put the source code into dubbo branch 2.6.6+, what's
> your opinion?
Do you mean put it into the core repository[1]?
We used to put these modules into different repositories.
But I think this leads to a problem that if more and more repositories
come in, it will be difficult to manage the releases.
This make me think that putting all the modules into the core repository.
The advantages are:
1. easy to manage the release of the modules like dubbo-registry-nacos
2. concentrate the users and contributors into one repository, it is
easy to track and identify the contributors
The disadvantage will be the all-in-one jar will be very large.
I think I prefer the first one: put dubbo-registry-nacos into core repository.
How do others think?
[1] https://github.com/apache/incubator-dubbo
>
> Kind regards,
>
> Mercy
>
> 在 2018/12/25 下午5:44, Huxing Zhang 写道:
> > Hi,
> >
> > On Sun, Dec 23, 2018 at 4:48 AM Justin Mclean <ju...@classsoftware.com> wrote:
> >> Hi,
> >>
> >>> Yes, both of them are Dubbo ppmc member.cI think we need a software grant here, shall we?
> >> Give both people involved have signed ICLAs and the code in Apache licensed it’s probably not required. It may depend on who actually owns the code (usually the company those people work for but it depends on their employment conditions and contract).
> > According to my knowledge, I think the company owns the code. It's
> > better to have a software grant there.
> >
> >> Thanks,
> >> Justin
> >
> >
--
Best Regards！
Huxing
Re: Donate dubbo-registry-nacos
Posted by Mercy <me...@apache.org>.
Hi,
I'd like to take the dubbo-registry-nacos as a registry
implementation and put the source code into dubbo branch 2.6.6+, what's
your opinion?
Kind regards,
Mercy
在 2018/12/25 下午5:44, Huxing Zhang 写道:
> Hi,
>
> On Sun, Dec 23, 2018 at 4:48 AM Justin Mclean <ju...@classsoftware.com> wrote:
>> Hi,
>>
>>> Yes, both of them are Dubbo ppmc member.cI think we need a software grant here, shall we?
>> Give both people involved have signed ICLAs and the code in Apache licensed it’s probably not required. It may depend on who actually owns the code (usually the company those people work for but it depends on their employment conditions and contract).
> According to my knowledge, I think the company owns the code. It's
> better to have a software grant there.
>
>> Thanks,
>> Justin
>
>
Re: Donate dubbo-registry-nacos
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
On Sun, Dec 23, 2018 at 4:48 AM Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> > Yes, both of them are Dubbo ppmc member.cI think we need a software grant here, shall we?
>
> Give both people involved have signed ICLAs and the code in Apache licensed it’s probably not required. It may depend on who actually owns the code (usually the company those people work for but it depends on their employment conditions and contract).
According to my knowledge, I think the company owns the code. It's
better to have a software grant there.
>
> Thanks,
> Justin
--
Best Regards！
Huxing
Re: Donate dubbo-registry-nacos
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Yes, both of them are Dubbo ppmc member.cI think we need a software grant here, shall we?
Give both people involved have signed ICLAs and the code in Apache licensed it’s probably not required. It may depend on who actually owns the code (usually the company those people work for but it depends on their employment conditions and contract).
Thanks,
Justin
Re: Donate dubbo-registry-nacos
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
On Thu, Dec 20, 2018 at 12:34 PM Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> Out of interest have the 2 contributors signed ICLAs?
Yes, both of them are Dubbo ppmc member.
I think we need a software grant here, shall we?
>
> Thanks,
> Justin
--
Best Regards！
Huxing
Re: Donate dubbo-registry-nacos
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Out of interest have the 2 contributors signed ICLAs?
Thanks,
Justin
Re: Donate dubbo-registry-nacos
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
+1 Accept the dubbo-registry-nacos into Apache Dubbo
On Thu, Dec 20, 2018 at 11:24 AM Mercy Ma <me...@apache.org> wrote:
>
> Hi, community,
>
> I'd like to donate dubbo-registry-nacos into dubbo and may rename to
> *incubator-dubbo-registry-**nacos*, and the source code is
> https://github.com/dubbo/dubbo-registry-nacos.
>
> Therefore I am calling a vote:
>
> [ ] +1 Accept the dubbo-registry-nacos into Dubbo
> [ ] -1 Do not accept the dubbo-registry-nacos into Dubbo
>
> Kind regards,
> Mercy Ma
--
Best Regards！
Huxing