[GitHub] [superset] rusackas commented on pull request #20144: feat: showing results pane in dashboard

[GitBox <gi...@apache.org>]

rusackas commented on PR #20144:
URL: https://github.com/apache/superset/pull/20144#issuecomment-1133358796

   Loving this!!
   
   Capturing a few UI/UX change requests that have come up in design feedback (CC @kasiazjc ❤️ )
   * In the modal header, instead of "View Results" maybe we could get more specific, like one of these:
     * {Name} Data
     * {Name} Results
     * Chart Data: {Name}
     * ... or others?
   * In the footer of the modal, can we add two buttons?
     * (left/secondary button) "Open in Explore" (or is this "Edit chart" now?)
     * (right/primary button) "Close"
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org