You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by li...@apache.org on 2024/08/06 06:08:37 UTC
(incubator-gluten) branch main updated: [GLUTEN-6686][CH] Disable percent_rank #6687
This is an automated email from the ASF dual-hosted git repository.
liuneng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 5cedfd1a3 [GLUTEN-6686][CH] Disable percent_rank #6687
5cedfd1a3 is described below
commit 5cedfd1a32b0ca60906fc70a7625ec519ed7cc01
Author: lgbo <lg...@gmail.com>
AuthorDate: Tue Aug 6 14:08:33 2024 +0800
[GLUTEN-6686][CH] Disable percent_rank #6687
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #6686
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
---
.../scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala | 3 +--
.../execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala b/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala
index 06fe8c34c..265750c2c 100644
--- a/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala
+++ b/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala
@@ -307,8 +307,7 @@ object CHBackendSettings extends BackendSettingsApi with Logging {
}
wExpression.windowFunction match {
- case _: RowNumber | _: AggregateExpression | _: Rank | _: DenseRank | _: PercentRank |
- _: NTile =>
+ case _: RowNumber | _: AggregateExpression | _: Rank | _: DenseRank | _: NTile =>
allSupported = allSupported
case l: Lag =>
checkLagOrLead(l.third)
diff --git a/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala b/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala
index 0efc1414c..912a5c95d 100644
--- a/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala
+++ b/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala
@@ -978,7 +978,7 @@ class GlutenClickHouseTPCHSaltNullParquetSuite extends GlutenClickHouseTPCHAbstr
compareResultsAgainstVanillaSpark(sql, true, { _ => })
}
- test("window percent_rank") {
+ ignore("window percent_rank") {
val sql =
"""
|select n_regionkey, n_nationkey,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org