You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "GitToTheHub (via GitHub)" <gi...@apache.org> on 2026/01/30 11:18:37 UTC
[PR] ios: rename `CDVCameraPicker` to `CDVImagePickerController` [cordova-plugin-camera]
GitToTheHub opened a new pull request, #948:
URL: https://github.com/apache/cordova-plugin-camera/pull/948
- Rename to `CDVImagePickerController` since it inherits from `UIImagePickerController` and is not only for taking pictures
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] ios: rename `CDVCameraPicker` to `CDVUIImagePickerController` [cordova-plugin-camera]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #948:
URL: https://github.com/apache/cordova-plugin-camera/pull/948#issuecomment-3824636909
I renamed it to `CDVUIImagePickerController` since it overwrites `UIImagePickerController` and keeping the full name is more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] ios: rename `CDVCameraPicker` to `CDVUIImagePickerController` [cordova-plugin-camera]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #948:
URL: https://github.com/apache/cordova-plugin-camera/pull/948#issuecomment-3824776833
Could it really be possible a plugin relies on `CDVCameraPicker`? I want to refactor the plugin and the renaming is done to better understand the code. It's confusing when it's sounds `CameraPicker` when it's in real an overwritten `UIImagePickerController`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] ios: rename `CDVCameraPicker` to `CDVUIImagePickerController` [cordova-plugin-camera]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #948:
URL: https://github.com/apache/cordova-plugin-camera/pull/948#issuecomment-3824811609
It's unknowable what people might be doing with custom code in their own apps, but currently it's part of the public exposed API for the plugin because it's in the header file.
If we want to change or rename it, that's fine, but it has to happen in a major version bump and be called out as a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] ios! rename `CDVCameraPicker` to `CDVUIImagePickerController` [cordova-plugin-camera]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub merged PR #948:
URL: https://github.com/apache/cordova-plugin-camera/pull/948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] ios: rename `CDVCameraPicker` to `CDVUIImagePickerController` [cordova-plugin-camera]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #948:
URL: https://github.com/apache/cordova-plugin-camera/pull/948#issuecomment-3824856142
Ok understand. This plugin is already bumped to 9.0.0, so it has already a major version bump. So I think it's ok to rename it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org