You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/05/25 07:50:09 UTC

[kudu-CR] [util] Support for entity types/ids/attrs/metrics filtering in metrics

Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13376

to look at the new patch set (#8).

Change subject: [util] Support for entity types/ids/attrs/metrics filtering in metrics
......................................................................

[util] Support for entity types/ids/attrs/metrics filtering in metrics

It takes a long time to display the metrics while there are
lots of tablets on the tserver, especially in web browsers.
So, I think it is good to support for entity types/ids/attrs/metrics
filtering in metrics.

Usage:
http://x.x.x.x:8050/metrics?types=type1,type2&ids=id1,id2&attributes=
table_name,table1,table_name,table2&metrics=on_disk_size,rows_inserted,
rows_upserted

Change-Id: I45ca55bd1f0f3d4107cb208f6f855d24121823ee
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/diagnostics_log.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
6 files changed, 269 insertions(+), 85 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/13376/8
-- 
To view, visit http://gerrit.cloudera.org:8080/13376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45ca55bd1f0f3d4107cb208f6f855d24121823ee
Gerrit-Change-Number: 13376
Gerrit-PatchSet: 8
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: helifu <hz...@corp.netease.com>