You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/24 07:32:26 UTC
[GitHub] [skywalking-query-protocol] liqiangz opened a new pull request #56: Support alarm tags
liqiangz opened a new pull request #56:
URL: https://github.com/apache/skywalking-query-protocol/pull/56
Support alarm tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] liqiangz commented on a change in pull request #56: Support alarm tags
Posted by GitBox <gi...@apache.org>.
liqiangz commented on a change in pull request #56:
URL: https://github.com/apache/skywalking-query-protocol/pull/56#discussion_r619632869
##########
File path: alarm.graphqls
##########
@@ -24,14 +24,20 @@ type AlarmMessage {
scope: Scope
id: ID!
message: String!
+ tags: [KeyValue!]!
}
type Alarms {
msgs: [AlarmMessage!]!
total: Int!
}
+input AlarmTag {
+ key: String!
+ value: String
+}
+
extend type Query {
getAlarmTrend(duration: Duration!): AlarmTrend!
- getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!): Alarms
+ getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!, tags: [AlarmTag]): Alarms
Review comment:
@wu-sheng Related issue https://github.com/apache/skywalking/issues/6821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng merged pull request #56: Support alarm tags
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #56:
URL: https://github.com/apache/skywalking-query-protocol/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #56: Support alarm tags
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #56:
URL: https://github.com/apache/skywalking-query-protocol/pull/56#discussion_r619605814
##########
File path: alarm.graphqls
##########
@@ -24,14 +24,20 @@ type AlarmMessage {
scope: Scope
id: ID!
message: String!
+ tags: [KeyValue!]!
}
type Alarms {
msgs: [AlarmMessage!]!
total: Int!
}
+input AlarmTag {
+ key: String!
+ value: String
+}
+
extend type Query {
getAlarmTrend(duration: Duration!): AlarmTrend!
- getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!): Alarms
+ getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!, tags: [AlarmTag]): Alarms
Review comment:
The old tag discussion is only related to notification, it makes sense to add this on about native/default UI. But still, the process is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #56: Support alarm tags
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #56:
URL: https://github.com/apache/skywalking-query-protocol/pull/56#discussion_r619605745
##########
File path: alarm.graphqls
##########
@@ -24,14 +24,20 @@ type AlarmMessage {
scope: Scope
id: ID!
message: String!
+ tags: [KeyValue!]!
}
type Alarms {
msgs: [AlarmMessage!]!
total: Int!
}
+input AlarmTag {
+ key: String!
+ value: String
+}
+
extend type Query {
getAlarmTrend(duration: Duration!): AlarmTrend!
- getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!): Alarms
+ getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!, tags: [AlarmTag]): Alarms
Review comment:
If you are asking for this change, please submit another new issue, we need to notify UI side PMC members, and get their approval.
##########
File path: alarm.graphqls
##########
@@ -24,14 +24,20 @@ type AlarmMessage {
scope: Scope
id: ID!
message: String!
+ tags: [KeyValue!]!
}
type Alarms {
msgs: [AlarmMessage!]!
total: Int!
}
+input AlarmTag {
+ key: String!
+ value: String
+}
+
extend type Query {
getAlarmTrend(duration: Duration!): AlarmTrend!
- getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!): Alarms
+ getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!, tags: [AlarmTag]): Alarms
Review comment:
The old tag discussion is only related to notification, it makes sense to add this on about native/default UI. But still, the process is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng merged pull request #56: Support alarm tags
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #56:
URL: https://github.com/apache/skywalking-query-protocol/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] liqiangz commented on a change in pull request #56: Support alarm tags
Posted by GitBox <gi...@apache.org>.
liqiangz commented on a change in pull request #56:
URL: https://github.com/apache/skywalking-query-protocol/pull/56#discussion_r619607434
##########
File path: alarm.graphqls
##########
@@ -24,14 +24,20 @@ type AlarmMessage {
scope: Scope
id: ID!
message: String!
+ tags: [KeyValue!]!
}
type Alarms {
msgs: [AlarmMessage!]!
total: Int!
}
+input AlarmTag {
+ key: String!
+ value: String
+}
+
extend type Query {
getAlarmTrend(duration: Duration!): AlarmTrend!
- getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!): Alarms
+ getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!, tags: [AlarmTag]): Alarms
Review comment:
I will open a issue later.
##########
File path: alarm.graphqls
##########
@@ -24,14 +24,20 @@ type AlarmMessage {
scope: Scope
id: ID!
message: String!
+ tags: [KeyValue!]!
}
type Alarms {
msgs: [AlarmMessage!]!
total: Int!
}
+input AlarmTag {
+ key: String!
+ value: String
+}
+
extend type Query {
getAlarmTrend(duration: Duration!): AlarmTrend!
- getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!): Alarms
+ getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!, tags: [AlarmTag]): Alarms
Review comment:
@wu-sheng Related issue https://github.com/apache/skywalking/issues/6821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] liqiangz commented on a change in pull request #56: Support alarm tags
Posted by GitBox <gi...@apache.org>.
liqiangz commented on a change in pull request #56:
URL: https://github.com/apache/skywalking-query-protocol/pull/56#discussion_r619607434
##########
File path: alarm.graphqls
##########
@@ -24,14 +24,20 @@ type AlarmMessage {
scope: Scope
id: ID!
message: String!
+ tags: [KeyValue!]!
}
type Alarms {
msgs: [AlarmMessage!]!
total: Int!
}
+input AlarmTag {
+ key: String!
+ value: String
+}
+
extend type Query {
getAlarmTrend(duration: Duration!): AlarmTrend!
- getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!): Alarms
+ getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!, tags: [AlarmTag]): Alarms
Review comment:
I will open a issue later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #56: Support alarm tags
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #56:
URL: https://github.com/apache/skywalking-query-protocol/pull/56#discussion_r619605745
##########
File path: alarm.graphqls
##########
@@ -24,14 +24,20 @@ type AlarmMessage {
scope: Scope
id: ID!
message: String!
+ tags: [KeyValue!]!
}
type Alarms {
msgs: [AlarmMessage!]!
total: Int!
}
+input AlarmTag {
+ key: String!
+ value: String
+}
+
extend type Query {
getAlarmTrend(duration: Duration!): AlarmTrend!
- getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!): Alarms
+ getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!, tags: [AlarmTag]): Alarms
Review comment:
If you are asking for this change, please submit another new issue, we need to notify UI side PMC members, and get their approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org