You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/14 06:39:29 UTC
Review Request: Explicitly disabled tests with the CgroupsIsolationModule
type parameter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9920/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/tests/environment.cpp 49027989be17f923b01a254325e4c1d6aaf80a24
Diff: https://reviews.apache.org/r/9920/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Explicitly disabled tests with the
CgroupsIsolationModule type parameter.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 14, 2013, 9:44 p.m., Thomas Marshall wrote:
> > src/tests/environment.cpp, line 90
> > <https://reviews.apache.org/r/9920/diff/1/?file=270420#file270420line90>
> >
> > This needs to be strings::contains as above and not == since tests will actually list their parameter as somethings more like "mesos::intermal::slave::CgroupsIsolationModule"
> >
> > With this patch submitted, we have again regressed to having the SlaveRecoveryTests fail on Ubuntu.
Ah, thanks for catching this Thomas! I'll prepare a fix.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9920/#review17923
-----------------------------------------------------------
On March 14, 2013, 5:39 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9920/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 5:39 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 49027989be17f923b01a254325e4c1d6aaf80a24
>
> Diff: https://reviews.apache.org/r/9920/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Explicitly disabled tests with the
CgroupsIsolationModule type parameter.
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9920/#review17923
-----------------------------------------------------------
src/tests/environment.cpp
<https://reviews.apache.org/r/9920/#comment37927>
This needs to be strings::contains as above and not == since tests will actually list their parameter as somethings more like "mesos::intermal::slave::CgroupsIsolationModule"
With this patch submitted, we have again regressed to having the SlaveRecoveryTests fail on Ubuntu.
- Thomas Marshall
On March 14, 2013, 5:39 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9920/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 5:39 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 49027989be17f923b01a254325e4c1d6aaf80a24
>
> Diff: https://reviews.apache.org/r/9920/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Explicitly disabled tests with the
CgroupsIsolationModule type parameter.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9920/#review17887
-----------------------------------------------------------
Ship it!
Was there a bug here, or was this just for clarity?
- Ben Mahler
On March 14, 2013, 5:39 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9920/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 5:39 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 49027989be17f923b01a254325e4c1d6aaf80a24
>
> Diff: https://reviews.apache.org/r/9920/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Explicitly disabled tests with the
CgroupsIsolationModule type parameter.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9920/#review17857
-----------------------------------------------------------
Ship it!
- Vinod Kone
On March 14, 2013, 5:39 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9920/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 5:39 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 49027989be17f923b01a254325e4c1d6aaf80a24
>
> Diff: https://reviews.apache.org/r/9920/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>