You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/05 15:08:37 UTC

[GitHub] [netbeans] lkishalmi opened a new pull request #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API

lkishalmi opened a new pull request #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API
URL: https://github.com/apache/netbeans/pull/2064
 
 
   There are similar implementations at least 3 places in NetBeans. This PR moves the one used in Gradle to be a reusable part of the Java Project UI API.
   Theoretically it would be easy to transform the existing uses to this new API, though I'd have a review first and even after that it might not be an urgent task to do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API
URL: https://github.com/apache/netbeans/pull/2064#discussion_r403825018
 
 

 ##########
 File path: groovy/gradle.java/src/org/netbeans/modules/gradle/java/customizer/CompileOptionsPanel.java
 ##########
 @@ -171,7 +146,7 @@ private void initComponents() {
         lbCompileOnSave = new javax.swing.JLabel();
         cbAugmentedBuild = new javax.swing.JCheckBox();
         lbPlatform = new javax.swing.JLabel();
-        cbPlatform = new javax.swing.JComboBox<>();
+        cbPlatform = PlatformsCustomizer.createPlatformComboBox(new PlatformComboBoxModel());
 
 Review comment:
   This usage could be replaced with the no-argument function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on issue #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API
URL: https://github.com/apache/netbeans/pull/2064#issuecomment-610469990
 
 
   I'm trying to add some unit tests at least for the model.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on a change in pull request #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API
URL: https://github.com/apache/netbeans/pull/2064#discussion_r403847341
 
 

 ##########
 File path: java/java.platform.ui/src/org/netbeans/api/java/platform/PlatformComboBoxModel.java
 ##########
 @@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.api.java.platform;
+
+import java.beans.PropertyChangeEvent;
+import java.beans.PropertyChangeListener;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import javax.swing.AbstractListModel;
+import javax.swing.ComboBoxModel;
+import org.openide.util.WeakListeners;
+
+/**
+ * A {@link ComboBoxModel} holding {@link JavaPlatform} references. The selected
+ * object can be a JavaPlatform or any object whose toString() method returns
+ * a registered Java Platform ID. This platform id can be obtained from a
+ * Java platform by getting its {@link #PROP_PLATFORM_ID} property.
+ * <pre>
+ *     JavaPlatform platform = &lt;some java platform&gt;
+ *     String id = platform.getProperties().get(PROP_PLATFORM_ID);
+ *     ...
+ *     PlatformComboBoxModel model = new PlatformComboBoxModel();
+ *     model.setSelectedItem(id);
+ * </pre>
+ *
+ * @since 1.51
+ * @author Laszlo Kishalmi
+ */
+public final class PlatformComboBoxModel extends AbstractListModel<JavaPlatform> implements ComboBoxModel<JavaPlatform>, PropertyChangeListener {
 
 Review comment:
   The updated PR does that. Good idea. Thank you!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi edited a comment on issue #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API

Posted by GitBox <gi...@apache.org>.
lkishalmi edited a comment on issue #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API
URL: https://github.com/apache/netbeans/pull/2064#issuecomment-609585601
 
 
   @JaroslavTulach thank you for the advises and the approval! I'd consider to create a Node based model, though unfortunately, I'm in rush finishing the new Gradle project wizards for 12.0 (if the RM would allow to put that in). This thing is just a side work coming out of that.
   
   BTW: Can I have your opinion on the "platform.ant.name" thing I mentioned earlier on this thread?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on issue #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API
URL: https://github.com/apache/netbeans/pull/2064#issuecomment-609585601
 
 
   @JaroslavTulach thank you for the advises and the approval! I'd consider to create a Node based model, though unfortunately, I'm in rush finishing the new Gradle project wizards for 12.0 (if the RM would allow to put that in). This thing is just a side work coming out of that.
   
   BTW: Can I have you opinion on the "platform.ant.name" thing I mentioned earlier on this thread?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API
URL: https://github.com/apache/netbeans/pull/2064#discussion_r403824575
 
 

 ##########
 File path: java/java.platform.ui/src/org/netbeans/api/java/platform/PlatformComboBoxModel.java
 ##########
 @@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.api.java.platform;
+
+import java.beans.PropertyChangeEvent;
+import java.beans.PropertyChangeListener;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import javax.swing.AbstractListModel;
+import javax.swing.ComboBoxModel;
+import org.openide.util.WeakListeners;
+
+/**
+ * A {@link ComboBoxModel} holding {@link JavaPlatform} references. The selected
+ * object can be a JavaPlatform or any object whose toString() method returns
+ * a registered Java Platform ID. This platform id can be obtained from a
+ * Java platform by getting its {@link #PROP_PLATFORM_ID} property.
+ * <pre>
+ *     JavaPlatform platform = &lt;some java platform&gt;
+ *     String id = platform.getProperties().get(PROP_PLATFORM_ID);
+ *     ...
+ *     PlatformComboBoxModel model = new PlatformComboBoxModel();
+ *     model.setSelectedItem(id);
+ * </pre>
+ *
+ * @since 1.51
+ * @author Laszlo Kishalmi
+ */
+public final class PlatformComboBoxModel extends AbstractListModel<JavaPlatform> implements ComboBoxModel<JavaPlatform>, PropertyChangeListener {
 
 Review comment:
   I suggest to hide this class behind factory method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on a change in pull request #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API
URL: https://github.com/apache/netbeans/pull/2064#discussion_r403847492
 
 

 ##########
 File path: groovy/gradle.java/src/org/netbeans/modules/gradle/java/customizer/CompileOptionsPanel.java
 ##########
 @@ -171,7 +146,7 @@ private void initComponents() {
         lbCompileOnSave = new javax.swing.JLabel();
         cbAugmentedBuild = new javax.swing.JCheckBox();
         lbPlatform = new javax.swing.JLabel();
-        cbPlatform = new javax.swing.JComboBox<>();
+        cbPlatform = PlatformsCustomizer.createPlatformComboBox(new PlatformComboBoxModel());
 
 Review comment:
   Done. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on issue #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #2064: [NETBEANS-4116] Add Java Platform ComboBox Support to the Java Platform UI API
URL: https://github.com/apache/netbeans/pull/2064#issuecomment-609433050
 
 
   Just a side note to this change, I think that the JavaPlatform.getProperties.get("platform.ant.name") would be worth to have it's own API in JavaPlatform like a String JavaPlatform.getInternalID().
   Maybe it was not planned to be used and exposed that much, however it is "extensively" used in the code as a commonly know "secret trick".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists