You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2023/03/15 11:06:58 UTC
[GitHub] [shardingsphere] yx9o opened a new issue, #24622: Naming Consistency Discussion: xxxUtil vs xxxUtils
yx9o opened a new issue, #24622:
URL: https://github.com/apache/shardingsphere/issues/24622
Hi Community:
I noticed that many tool classes are named, some are `xxxUtil`, some are `xxxUtils`.
I think the style should be unified.
Please share your thoughts.
For example:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu closed issue #24622: Naming Consistency Discussion: xxxUtil vs xxxUtils
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed issue #24622: Naming Consistency Discussion: xxxUtil vs xxxUtils
URL: https://github.com/apache/shardingsphere/issues/24622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #24622: Naming Consistency Discussion: xxxUtil vs xxxUtils
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #24622:
URL: https://github.com/apache/shardingsphere/issues/24622#issuecomment-1469900449
I think `xxUtils` is better, a Utility class often contains multiple utility methods.
For reference, the following are some commonly used utility classes:
### Apache
- org.apache.commons.lang3.StringUtils
- org.apache.commons.io.IOUtils
- org.apache.zookeeper.util.ServiceUtils
### Google
- com.google.common.math.DoubleUtils
- com.google.api.client.util.IOUtils
### Amazonaws
- com.amazonaws.util.StringUtils
- com.amazonaws.util.NumberUtils
### Spring
- org.springframework.util.StringUtils
- org.springframework.util.CollectionUtils
- org.springframework.util.StreamUtils
- org.springframework.util.DigestUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on issue #24622: Naming Consistency Discussion: xxxUtil vs xxxUtils
Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on issue #24622:
URL: https://github.com/apache/shardingsphere/issues/24622#issuecomment-1478915047
@RaigorJiang Alright, I will complete it as soon as possible. Please assign to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #24622: Naming Consistency Discussion: xxxUtil vs xxxUtils
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on issue #24622:
URL: https://github.com/apache/shardingsphere/issues/24622#issuecomment-1478845969
Great, +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #24622: Naming Consistency Discussion: xxxUtil vs xxxUtils
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #24622:
URL: https://github.com/apache/shardingsphere/issues/24622#issuecomment-1478109537
Hi @yx9o
Seems uncontroversial, do you plan to start this refactoring?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #24622: Naming Consistency Discussion: xxxUtil vs xxxUtils
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #24622:
URL: https://github.com/apache/shardingsphere/issues/24622#issuecomment-1478848335
@yx9o
Thanks for your proposal. In addition, please also update the code specification to let everyone know the name of utility class, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #24622: Naming Consistency Discussion: xxxUtil vs xxxUtils
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #24622:
URL: https://github.com/apache/shardingsphere/issues/24622#issuecomment-1471178980
I also think `xxUtils` is better. We need to be consistent with mainstream open source projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org