[GitHub] [pulsar] merlimat commented on a diff in pull request #17403: [improve][broker] Using `handle` instead of `handleAsync` to avoid using common pool thread

[GitBox <gi...@apache.org>]

merlimat commented on code in PR #17403:
URL: https://github.com/apache/pulsar/pull/17403#discussion_r960992246


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/BookkeeperSchemaStorage.java:
##########
@@ -213,7 +213,7 @@ private CompletableFuture<StoredSchema> getSchema(String schemaId) {
                 return readSchemaEntry(schemaLocator.getInfo().getPosition())
                         .thenApply(entry -> new StoredSchema(entry.getSchemaData().toByteArray(),
                                 new LongSchemaVersion(schemaLocator.getInfo().getVersion())));
-            }).handleAsync((res, ex) -> {
+            }).handle((res, ex) -> {

Review Comment:
   @Technoboy- There were 2 instances of `handleAsync()` in the original commit, should we change both?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org