You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/02 21:03:46 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6616: NIFI-10749 Correct Windows NPM Cache for GitHub Workflow

exceptionfactory opened a new pull request, #6616:
URL: https://github.com/apache/nifi/pull/6616

   # Summary
   
   [NIFI-10749](https://issues.apache.org/jira/browse/NIFI-10749) Corrects the Windows NPM cache configuration for GitHub workflow actions.
   
   The changes remove the custom step to get the NPM cache directory and instead rely on the default NPM cache location for Windows, which is the current user's home directory, followed by `\AppData\npm-cache`.
   
   The corrected behavior can be observed in the `Post Cache Node Modules` step indicating that the cache contains saved files.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #6616: NIFI-10749 Correct Windows NPM Cache for GitHub Workflow

Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6616:
URL: https://github.com/apache/nifi/pull/6616#issuecomment-1302262645

   +1 LGTM, thanks for the fix! Merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 closed pull request #6616: NIFI-10749 Correct Windows NPM Cache for GitHub Workflow

Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6616: NIFI-10749 Correct Windows NPM Cache for GitHub Workflow
URL: https://github.com/apache/nifi/pull/6616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #6616: NIFI-10749 Correct Windows NPM Cache for GitHub Workflow

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6616:
URL: https://github.com/apache/nifi/pull/6616#issuecomment-1301462718

   See the following GitHub Action run for an example of the NPM cache success for Windows:
   
   https://github.com/exceptionfactory/nifi/actions/runs/3381071846/jobs/5614633106


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org