[GitHub] [libcloud] vdloo commented on pull request #1474: Add ex_get_network to openstack driver

[GitBox <gi...@apache.org>]

vdloo commented on pull request #1474:
URL: https://github.com/apache/libcloud/pull/1474#issuecomment-659431515


   Tested both the v1 and v2 driver, both work fine:
   
   The OpenStack_1_1_NodeDriver:
   ```py
   In [12]: conn.__class__.__bases__
   Out[12]: (libcloud.compute.drivers.openstack.OpenStack_1_1_NodeDriver,)
   
   In [13]: network_id = conn.ex_list_networks()[0].id
   
   In [14]: conn.ex_get_network(network_id)
   Out[14]: <OpenStackNetwork id="123c6b6a-1234-3a1f-b404-1234365f4b22" name="L2_NETWORK" cidr="None">
   ```
   
   The OpenStack_2_NodeDriver:
   ```py
   In [3]: conn.__class__.__bases__
   Out[3]: (libcloud.compute.drivers.openstack.OpenStack_2_NodeDriver,)
   
   In [4]: network_id = conn.ex_list_networks()[0].id
   
   In [5]: conn.ex_get_network(network_id)
   Out[5]: <OpenStackNetwork id="123c6b6a-1234-3a1f-b404-1234365f4b22" name="L2_NETWORK" cidr="None">
   ```
   
   The failing tests (scrape-and-publish-provider-prices) are unrelated.
   
   lgtm :+1:
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org