You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "omkenge (via GitHub)" <gi...@apache.org> on 2024/10/17 19:37:01 UTC

[PR] feat: Add support for YYYYMMDD date formats [iceberg-python]

omkenge opened a new pull request, #1234:
URL: https://github.com/apache/iceberg-python/pull/1234

   ### Support for Additional Date Format
   
   #### Summary
   This PR extends the date/time handling functions by adding support for one additional formats:
   - `YYYYMMDD` (e.g., `20241018`)
   
   #### Changes
   - Updated the `date_str_to_days` function to handle the `YYYYMMDD` date format
   - Added corresponding regex patterns to match these formats.
   
   Please @kevinjqliu reviewthis and provide feedback!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] feat: Add support for YYYYMMDD date formats [iceberg-python]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2420893458

   hey @omkenge, thanks for the PR. What use case is this for? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] feat: Add support for YYYYMMDD date formats [iceberg-python]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424162564

   @omkenge do you mind creating an issue first? We can have a discussion and allow others to chime in before starting the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] feat: Add support for YYYYMMDD date formats [iceberg-python]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424128401

   Thanks for the context! 
   
   My opinion is that it's best not to add the `YYYYMMDD` format to the pyiceberg library. Here are my reasoning.
   - I think date parsing can be done outside of the pyiceberg library. For example, we can transform date strings from `YYYYMMDD` to the currently supported ISO-8601 format (`YYYY-MM-DD`).
   - Supporting yet another date string format adds more complexity. If we support `YYYYMMDD`, why not also support `MMDDYYYY`? 
   
   I think its best to only support ISO-8601 (`YYYY-MM-DD`) in the pyiceberg library and have other date strings transform to this format. 
   
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] feat: Add support for YYYYMMDD date formats [iceberg-python]

Posted by "omkenge (via GitHub)" <gi...@apache.org>.
omkenge commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424103667

   Hey @kevinjqliu sorry for the late reply ...
   So talking about use cases ..
   Many legacy systems and industries (e.g., government sectors) store dates in compact YYYYMMDD format. 
   Supporting YYYYMMDD allows developers to work seamlessly with historical datasets without needing to pre-process them.
   As I am working in a Mechatronics company, the YYYYMMDD format is crucial for handling machine-generated data in areas such as maintenance schedules, log entries, and component tracking. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] feat: Add support for YYYYMMDD date formats [iceberg-python]

Posted by "omkenge (via GitHub)" <gi...@apache.org>.
omkenge closed pull request #1234: feat: Add support for YYYYMMDD date formats
URL: https://github.com/apache/iceberg-python/pull/1234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] feat: Add support for YYYYMMDD date formats [iceberg-python]

Posted by "omkenge (via GitHub)" <gi...@apache.org>.
omkenge commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424141706

   and also i have some suggestions on other parts also , i will create PR as soon as possible 
   Plz also share your thoughts on that part also
   Thank you for your time 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] feat: Add support for YYYYMMDD date formats [iceberg-python]

Posted by "omkenge (via GitHub)" <gi...@apache.org>.
omkenge commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424140033

   Thank you for your feedback! I understand your concerns.
   Ok then lets keep it simple and we can closed this PR with your final comment ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org