You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2017/06/14 01:02:23 UTC

[GitHub] zeppelin issue #2407: [ZEPPELIN-1907] Shell Interpreter does not renew ticke...

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2407
  
    @prabhjyotsingh I left one minor comment. Besides that I found 1 other issues.  
    
    * Code duplication and inconsistency between `ShellInterpreter` and `ShellSecurityImpl`. Both of these 2 classes will create DefaultExecutor and do the real  shell execution. But it seems the command in `ShellSecurityImpl` can not be canceled, because it is not put in `executors`. It would be better to put the common logic together. 
    
    But this issue is not related with this ticket, could be done in another ticket. 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---