[GitHub] [netbeans] matthiasblaesing commented on issue #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like.

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like.
URL: https://github.com/apache/netbeans/pull/1497#issuecomment-531182362
 
 
   I think @eirikbakke is in a better position to answer this, but my understand is, that using an ImageIcon forces you to use an Image as basis for your icon, you can't back it with other implementations. Using a plain Icon allows you to switch implementations under the hood without affecting the users.
   
   Using an image for an icon is trivial, but an Icon could be drawn by java code or could be backed by an SVG that is scaled and rendered at the right size.
   
   I had a quick look at this and it seems, that the problem can be tracked down into `org.netbeans.spi.editor.completion.support.CompletionUtilities#renderHtml` that method expects an `ImageIcon`. So to remove the requirement, the whole chain from `editor.completion` to the groovy editor would need to be fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists