You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/01 15:46:42 UTC

[GitHub] [iceberg] Fokko commented on a diff in pull request #4844: Add Poetry build and release instructions

Fokko commented on code in PR #4844:
URL: https://github.com/apache/iceberg/pull/4844#discussion_r886963843


##########
python/README.md:
##########
@@ -30,26 +30,27 @@ cd iceberg/python
 pip install -e .
 ```
 
-## Testing
+Development is made easy using [Poetry](https://python-poetry.org/docs/#installation). 
 
-Testing is done using tox. The config can be found in `tox.ini` within the python directory of the iceberg project.
+## Development

Review Comment:
   Cool, I've added the commands 👍🏻  btw, some interesting combinations you have there. `sudo` shouldn't be required, and `pip install` and `python3 -m pip install` are equivalent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org