[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6374: Update to object_store 0.6 and arrow 41

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #6374:
URL: https://github.com/apache/arrow-datafusion/pull/6374#discussion_r1219509184


##########
datafusion-examples/examples/parquet_sql_multiple_files.rs:
##########
@@ -40,7 +40,7 @@ async fn main() -> Result<()> {
     // for the query
     ctx.register_listing_table(
         "my_table",
-        &format!("file://{testdata}"),
+        &format!("file://{testdata}/alltypes_plain.parquet"),

Review Comment:
   This is a nice validation of https://github.com/apache/arrow-rs/issues/4230 being a valuable change. This test was broken, as the lack of a trailing `/` meant it wouldn't list the directory, and this meant it silently failed to list any files. Schema inference fails on the root directory (correctly) so I changed this to a single file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org