You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "ryankert01 (via GitHub)" <gi...@apache.org> on 2025/12/08 02:56:10 UTC

[PR] [MINOR][QDP] update uv usage in qdp-python [mahout]

ryankert01 opened a new pull request, #698:
URL: https://github.com/apache/mahout/pull/698

   ### Purpose of PR
   <!-- Describe what this PR does. -->
   
   ### Related Issues or PRs
   <!-- Add links to related issues or PRs. -->
   <!-- - Closes #123  -->
   <!-- - Related to #123   -->
   
   ### Changes Made
   <!-- Please mark one with an "x"   -->
   - [ ] Bug fix
   - [ ] New feature
   - [ ] Refactoring
   - [ ] Documentation
   - [ ] Test
   - [ ] CI/CD pipeline
   - [ ] Other
   
   ### Breaking Changes
   <!-- Does this PR introduce a breaking change? -->
   - [ ] Yes
   - [ ] No
   
   ### Checklist
   <!-- Please mark each item with an "x" when complete -->
   <!-- If not all items are complete, please open this as a **Draft PR**.
   Once all requirements are met, mark as ready for review. -->
   
   - [ ] Added or updated unit tests for all changes
   - [ ] Added or updated documentation for all changes
   - [ ] Successfully built and ran all unit tests or manual tests locally
   - [ ] PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
   - [ ] Code follows ASF guidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR][QDP] update uv usage in qdp-python [mahout]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming merged PR #698:
URL: https://github.com/apache/mahout/pull/698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR][QDP] update uv usage in qdp-python [mahout]

Posted by "ryankert01 (via GitHub)" <gi...@apache.org>.
ryankert01 commented on code in PR #698:
URL: https://github.com/apache/mahout/pull/698#discussion_r2596896867


##########
qdp/qdp-python/README.md:
##########
@@ -16,9 +16,13 @@ dlpack_ptr = engine.encode(data, num_qubits=2, encoding_method="amplitude")
 ```
 
 ## Build from source
-
 ```bash
-uv sync --extra dev
+# add a uv python 3.11 environment
+uv venv -p python3.11
+source .venv/bin/activate
+```
+```bash
+uv sync --group dev

Review Comment:
   I personally cannot use `--extra`, because of following(from chatgpt):
   dependency-groups 是 Hatch/uv 新格式，但要用 uv sync --group dev



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR][QDP] update uv usage in qdp-python [mahout]

Posted by "ryankert01 (via GitHub)" <gi...@apache.org>.
ryankert01 commented on PR #698:
URL: https://github.com/apache/mahout/pull/698#issuecomment-3624374903

   PTAL @rich7420 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR][QDP] update uv usage in qdp-python [mahout]

Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on code in PR #698:
URL: https://github.com/apache/mahout/pull/698#discussion_r2596902317


##########
qdp/qdp-python/README.md:
##########
@@ -16,9 +16,13 @@ dlpack_ptr = engine.encode(data, num_qubits=2, encoding_method="amplitude")
 ```
 
 ## Build from source
-
 ```bash
-uv sync --extra dev
+# add a uv python 3.11 environment
+uv venv -p python3.11
+source .venv/bin/activate
+```
+```bash
+uv sync --group dev

Review Comment:
   I think it's right!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR][QDP] update uv usage in qdp-python [mahout]

Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #698:
URL: https://github.com/apache/mahout/pull/698#issuecomment-3624388682

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org