[GitHub] [incubator-superset] enricoberti commented on a change in pull request #7083: [SQL Lab] Remove double scrollbar from the result tab

[GitBox <gi...@apache.org>]

enricoberti commented on a change in pull request #7083: [SQL Lab] Remove double scrollbar from the result tab
URL: https://github.com/apache/incubator-superset/pull/7083#discussion_r268069529
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/ResultSet.jsx
 ##########
 @@ -51,7 +51,7 @@ const defaultProps = {
   database: {},
 };
 
-const SEARCH_HEIGHT = 46;
+const SEARCH_HEIGHT = 186;
 
 Review comment:
   as it was, the result table was going out of the screen (last row never visible, unless you would scroll the outer panel)
   
   I'm generally against magic numbers in the code though, so we should probably find a proper solution for it (ie calculating the sibling heights after rendering) :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org