You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "balajinima (via GitHub)" <gi...@apache.org> on 2023/05/05 09:29:42 UTC

[GitHub] [dolphinscheduler] balajinima commented on issue #14032: [Bug] [worker] When killing tasks in Worker, the thread executing the task is not actually closed

balajinima commented on issue #14032:
URL: https://github.com/apache/dolphinscheduler/issues/14032#issuecomment-1535985344

   
   I simulated the scenario of a time-consuming SQL execution being killed, but after the task instance is stopped, the background task thread is still running without interruption and release of resources from the database session, which can be verified on the monitoring page. Upon checking the code, I found that the cancel() method of sqltask does not perform any operation and is empty. 
   In this situation, there is a certain probability that it will affect the task's re-do. 
   I think that interrupting the thread may be a good solution, and doing future.cancel operations on the threads in the thread pool. What do you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org