You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/12 23:49:06 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #22966: Update tree doc references to grid
bbovenzi opened a new pull request, #22966:
URL: https://github.com/apache/airflow/pull/22966
Swap images of tree view to images of grid view.
Also, expand upon the new features of grid view in `ui.rst` with new screenshots.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #22966: Update tree doc references to grid
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #22966:
URL: https://github.com/apache/airflow/pull/22966#discussion_r849018184
##########
docs/apache-airflow/ui.rst:
##########
@@ -46,24 +46,39 @@ For example:
------------
-Tree View
+Grid View
.........
-A tree representation of the DAG that spans across time. If a pipeline is
-late, you can quickly see where the different steps are and identify
+A bar chart and grid representation of the DAG that spans across time.
+The top row is a chart of Dag Runs by duration,
+and below, task instances. If a pipeline is late,
+you can quickly see where the different steps are and identify
the blocking ones.
-There is also visual difference between scheduled and manually triggered
-DAGs/tasks:
+The details panel will update when selecting a DAG Run by clicking on a duration bar:
+
+.. image:: img/grid_run_details.png
+
+Or selecting a Task Instance by clicking on a status box:
+
+.. image:: img/grid_instance_details.png
+
+Manual runs are indicated by a play icon (just like the Trigger DAG button):
.. image:: img/task_manual_vs_scheduled.png
-The DAGs/tasks with a black border are scheduled runs, whereas the non-bordered
-DAGs/tasks are manually triggered, i.e. by ``airflow dags trigger``.
+Task groups are indicated by a caret and can be opened or closed
+
+.. image:: img/grid_task_group.png
+
+Mapped Tasks are indicated by a square brackets and will show a table of each mapped instance in the details panel:
+
+.. image:: img/grid_mapped_task.png
+
------------
-.. image:: img/tree.png
+.. image:: img/grid.png
Review Comment:
Sorry, more specifically the first screenshot in the grid section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #22966: Update tree doc references to grid
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #22966:
URL: https://github.com/apache/airflow/pull/22966#discussion_r848963223
##########
docs/apache-airflow/ui.rst:
##########
@@ -46,24 +46,39 @@ For example:
------------
-Tree View
+Grid View
.........
-A tree representation of the DAG that spans across time. If a pipeline is
-late, you can quickly see where the different steps are and identify
+A bar chart and grid representation of the DAG that spans across time.
+The top row is a chart of Dag Runs by duration,
+and below, task instances. If a pipeline is late,
+you can quickly see where the different steps are and identify
the blocking ones.
-There is also visual difference between scheduled and manually triggered
-DAGs/tasks:
+The details panel will update when selecting a DAG Run by clicking on a duration bar:
+
+.. image:: img/grid_run_details.png
+
+Or selecting a Task Instance by clicking on a status box:
+
+.. image:: img/grid_instance_details.png
+
+Manual runs are indicated by a play icon (just like the Trigger DAG button):
.. image:: img/task_manual_vs_scheduled.png
-The DAGs/tasks with a black border are scheduled runs, whereas the non-bordered
-DAGs/tasks are manually triggered, i.e. by ``airflow dags trigger``.
+Task groups are indicated by a caret and can be opened or closed
+
+.. image:: img/grid_task_group.png
+
+Mapped Tasks are indicated by a square brackets and will show a table of each mapped instance in the details panel:
Review Comment:
```suggestion
Mapped Tasks are indicated by a square brackets and will show a table of each mapped task instance in the details panel:
```
##########
docs/apache-airflow/ui.rst:
##########
@@ -46,24 +46,39 @@ For example:
------------
-Tree View
+Grid View
.........
-A tree representation of the DAG that spans across time. If a pipeline is
-late, you can quickly see where the different steps are and identify
+A bar chart and grid representation of the DAG that spans across time.
+The top row is a chart of Dag Runs by duration,
+and below, task instances. If a pipeline is late,
+you can quickly see where the different steps are and identify
the blocking ones.
-There is also visual difference between scheduled and manually triggered
-DAGs/tasks:
+The details panel will update when selecting a DAG Run by clicking on a duration bar:
+
+.. image:: img/grid_run_details.png
+
+Or selecting a Task Instance by clicking on a status box:
+
+.. image:: img/grid_instance_details.png
+
+Manual runs are indicated by a play icon (just like the Trigger DAG button):
.. image:: img/task_manual_vs_scheduled.png
-The DAGs/tasks with a black border are scheduled runs, whereas the non-bordered
-DAGs/tasks are manually triggered, i.e. by ``airflow dags trigger``.
+Task groups are indicated by a caret and can be opened or closed
Review Comment:
```suggestion
Task groups are indicated by a caret and can be opened or closed:
```
##########
docs/apache-airflow/ui.rst:
##########
@@ -46,24 +46,39 @@ For example:
------------
-Tree View
+Grid View
.........
-A tree representation of the DAG that spans across time. If a pipeline is
-late, you can quickly see where the different steps are and identify
+A bar chart and grid representation of the DAG that spans across time.
+The top row is a chart of Dag Runs by duration,
+and below, task instances. If a pipeline is late,
+you can quickly see where the different steps are and identify
the blocking ones.
-There is also visual difference between scheduled and manually triggered
-DAGs/tasks:
+The details panel will update when selecting a DAG Run by clicking on a duration bar:
+
+.. image:: img/grid_run_details.png
+
+Or selecting a Task Instance by clicking on a status box:
+
+.. image:: img/grid_instance_details.png
+
+Manual runs are indicated by a play icon (just like the Trigger DAG button):
.. image:: img/task_manual_vs_scheduled.png
-The DAGs/tasks with a black border are scheduled runs, whereas the non-bordered
-DAGs/tasks are manually triggered, i.e. by ``airflow dags trigger``.
+Task groups are indicated by a caret and can be opened or closed
+
+.. image:: img/grid_task_group.png
+
+Mapped Tasks are indicated by a square brackets and will show a table of each mapped instance in the details panel:
+
+.. image:: img/grid_mapped_task.png
+
------------
-.. image:: img/tree.png
+.. image:: img/grid.png
Review Comment:
I wonder if we should move this up to be the first screenshot.
##########
chart/Chart.yaml:
##########
@@ -48,8 +48,8 @@ annotations:
artifacthub.io/screenshots: |
- title: DAGs View
url: https://airflow.apache.org/docs/apache-airflow/2.2.5/_images/dags.png
- - title: Tree View
- url: https://airflow.apache.org/docs/apache-airflow/2.2.5/_images/tree.png
+ - title: Grid View
+ url: https://airflow.apache.org/docs/apache-airflow/2.2.5/_images/grid.png
Review Comment:
```suggestion
- title: Tree View
url: https://airflow.apache.org/docs/apache-airflow/2.2.5/_images/tree.png
```
Thanks for being proactive, but this will need to wait until the next helm chart release after 2.3.0 launches.
Said another way, this is a follow up step after releasing a core Airflow version, when we make the new version the chart default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #22966: Update tree doc references to grid
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #22966:
URL: https://github.com/apache/airflow/pull/22966#discussion_r848988683
##########
chart/Chart.yaml:
##########
@@ -48,8 +48,8 @@ annotations:
artifacthub.io/screenshots: |
- title: DAGs View
url: https://airflow.apache.org/docs/apache-airflow/2.2.5/_images/dags.png
- - title: Tree View
- url: https://airflow.apache.org/docs/apache-airflow/2.2.5/_images/tree.png
+ - title: Grid View
+ url: https://airflow.apache.org/docs/apache-airflow/2.2.5/_images/grid.png
Review Comment:
So remove this change for now and do it in a later PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #22966: Update tree doc references to grid
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #22966:
URL: https://github.com/apache/airflow/pull/22966#discussion_r849128065
##########
docs/apache-airflow/ui.rst:
##########
@@ -46,24 +46,39 @@ For example:
------------
-Tree View
+Grid View
.........
-A tree representation of the DAG that spans across time. If a pipeline is
-late, you can quickly see where the different steps are and identify
+A bar chart and grid representation of the DAG that spans across time.
+The top row is a chart of Dag Runs by duration,
Review Comment:
```suggestion
The top row is a chart of DAG Runs by duration,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #22966: Update tree doc references to grid
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #22966:
URL: https://github.com/apache/airflow/pull/22966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #22966: Update tree doc references to grid
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #22966:
URL: https://github.com/apache/airflow/pull/22966#discussion_r848988132
##########
docs/apache-airflow/ui.rst:
##########
@@ -46,24 +46,39 @@ For example:
------------
-Tree View
+Grid View
.........
-A tree representation of the DAG that spans across time. If a pipeline is
-late, you can quickly see where the different steps are and identify
+A bar chart and grid representation of the DAG that spans across time.
+The top row is a chart of Dag Runs by duration,
+and below, task instances. If a pipeline is late,
+you can quickly see where the different steps are and identify
the blocking ones.
-There is also visual difference between scheduled and manually triggered
-DAGs/tasks:
+The details panel will update when selecting a DAG Run by clicking on a duration bar:
+
+.. image:: img/grid_run_details.png
+
+Or selecting a Task Instance by clicking on a status box:
+
+.. image:: img/grid_instance_details.png
+
+Manual runs are indicated by a play icon (just like the Trigger DAG button):
.. image:: img/task_manual_vs_scheduled.png
-The DAGs/tasks with a black border are scheduled runs, whereas the non-bordered
-DAGs/tasks are manually triggered, i.e. by ``airflow dags trigger``.
+Task groups are indicated by a caret and can be opened or closed
+
+.. image:: img/grid_task_group.png
+
+Mapped Tasks are indicated by a square brackets and will show a table of each mapped instance in the details panel:
+
+.. image:: img/grid_mapped_task.png
+
------------
-.. image:: img/tree.png
+.. image:: img/grid.png
Review Comment:
Isn't the first screenshot the DAGs view of the homepage? I feel like we should leave that as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22966: Update tree doc references to grid
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22966:
URL: https://github.com/apache/airflow/pull/22966#issuecomment-1098109607
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #22966: Update tree doc references to grid
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #22966:
URL: https://github.com/apache/airflow/pull/22966#discussion_r849017774
##########
chart/Chart.yaml:
##########
@@ -48,8 +48,8 @@ annotations:
artifacthub.io/screenshots: |
- title: DAGs View
url: https://airflow.apache.org/docs/apache-airflow/2.2.5/_images/dags.png
- - title: Tree View
- url: https://airflow.apache.org/docs/apache-airflow/2.2.5/_images/tree.png
+ - title: Grid View
+ url: https://airflow.apache.org/docs/apache-airflow/2.2.5/_images/grid.png
Review Comment:
Yep exactly, when we hit this step in the release process:
https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md#update-default-airflow-version-in-the-helm-chart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org