You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by re...@apache.org on 2012/05/04 13:02:34 UTC

svn commit: r1333876 - in /incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core: persistence/validation/entity/PolicyValidator.java policy/PolicyEvaluator.java

Author: rene
Date: Fri May  4 11:02:33 2012
New Revision: 1333876

URL: http://svn.apache.org/viewvc?rev=1333876&view=rev
Log:
sonar: remove duplicate code in switch statement

Modified:
    incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/PolicyValidator.java
    incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/PolicyEvaluator.java

Modified: incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/PolicyValidator.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/PolicyValidator.java?rev=1333876&r1=1333875&r2=1333876&view=diff
==============================================================================
--- incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/PolicyValidator.java (original)
+++ incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/PolicyValidator.java Fri May  4 11:02:33 2012
@@ -72,9 +72,6 @@ public class PolicyValidator extends Abs
                 }
                 break;
 
-            case PASSWORD:
-                break;
-
             case GLOBAL_ACCOUNT:
 
                 // just one GLOBAL_ACCOUNT policy
@@ -89,9 +86,6 @@ public class PolicyValidator extends Abs
                 }
                 break;
 
-            case ACCOUNT:
-                break;
-
             case GLOBAL_SYNC:
 
                 // just one GLOBAL_SYNC policy
@@ -106,6 +100,8 @@ public class PolicyValidator extends Abs
                 }
                 break;
 
+            case PASSWORD:
+            case ACCOUNT:
             case SYNC:
             default:
         }

Modified: incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/PolicyEvaluator.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/PolicyEvaluator.java?rev=1333876&r1=1333875&r2=1333876&view=diff
==============================================================================
--- incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/PolicyEvaluator.java (original)
+++ incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/PolicyEvaluator.java Fri May  4 11:02:33 2012
@@ -112,8 +112,6 @@ public class PolicyEvaluator {
                     break;
                 case SYNC:
                 case GLOBAL_SYNC:
-                    result = null;
-                    break;
                 default:
                     result = null;
             }