You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/12/01 05:30:03 UTC
Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/
-----------------------------------------------------------
Review request for mesos, Dominic Hamon and Joris Van Remoortere.
Repository: mesos-git
Description
-------
Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
Diffs
-----
3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
Diff: https://reviews.apache.org/r/28545/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/#review63338
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28543, 28544, 28545]
All tests passed.
- Mesos ReviewBot
On Dec. 1, 2014, 4:30 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28545/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 4:30 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
> 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
> 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
> 3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
> 3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
>
> Diff: https://reviews.apache.org/r/28545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/
-----------------------------------------------------------
(Updated Dec. 3, 2014, 2:16 p.m.)
Review request for mesos, Dominic Hamon and Joris Van Remoortere.
Repository: mesos-git
Description
-------
Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
Diffs (updated)
-----
3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
Diff: https://reviews.apache.org/r/28545/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Dec. 2, 2014, 10:04 a.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 69
> > <https://reviews.apache.org/r/28545/diff/2/?file=779866#file779866line69>
> >
> > add a family - may as well get used to it.
>
> Evelina Dumitrescu wrote:
> Wouldn't it be better if I leave this as it is? I was thinking that Node will contain a field net::IP for the ip address and net::IP will contain the family type. I have written this also on the previous revision.
ok
> On Dec. 2, 2014, 10:04 a.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/net.hpp, line 47
> > <https://reviews.apache.org/r/28545/diff/2/?file=779869#file779869line47>
> >
> > you're in the process namespace.
>
> Evelina Dumitrescu wrote:
> I don't see any namespace process declared here.
huh. you're right. that's probably an oversight that we should correct to avoid polluting the global namespace. another patch though :)
> On Dec. 2, 2014, 10:04 a.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/net.hpp, line 73
> > <https://reviews.apache.org/r/28545/diff/2/?file=779869#file779869line73>
> >
> > this cast makes me uncomfortable. should the Node constructor take an in_addr?
>
> Evelina Dumitrescu wrote:
> Sure, I will add another patch for this. But it will be replaced soon by net::IP.
if you have a plan to replace it, then don't worry.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/#review63554
-----------------------------------------------------------
On Dec. 3, 2014, 6:16 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28545/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 6:16 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
> 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
> 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
> 3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
> 3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
> 3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
>
> Diff: https://reviews.apache.org/r/28545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Dec. 2, 2014, 6:04 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 69
> > <https://reviews.apache.org/r/28545/diff/2/?file=779866#file779866line69>
> >
> > add a family - may as well get used to it.
Wouldn't it be better if I leave this as it is? I was thinking that Node will contain a field net::IP for the ip address and net::IP will contain the family type. I have written this also on the previous revision.
> On Dec. 2, 2014, 6:04 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/net.hpp, line 73
> > <https://reviews.apache.org/r/28545/diff/2/?file=779869#file779869line73>
> >
> > this cast makes me uncomfortable. should the Node constructor take an in_addr?
Sure, I will add another patch for this. But it will be replaced soon by net::IP.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/#review63554
-----------------------------------------------------------
On Dec. 2, 2014, 2:07 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28545/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 2:07 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
> 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
> 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
> 3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
> 3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
>
> Diff: https://reviews.apache.org/r/28545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Dec. 2, 2014, 6:04 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/net.hpp, line 47
> > <https://reviews.apache.org/r/28545/diff/2/?file=779869#file779869line47>
> >
> > you're in the process namespace.
I don't see any namespace process declared here.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/#review63554
-----------------------------------------------------------
On Dec. 2, 2014, 2:07 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28545/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 2:07 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
> 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
> 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
> 3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
> 3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
>
> Diff: https://reviews.apache.org/r/28545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/#review63554
-----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/28545/#comment105819>
no need for braces around this default.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/28545/#comment105820>
add a family .. may as well get used to it :)
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/28545/#comment105821>
add a family - may as well get used to it.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/28545/#comment105822>
no need for braces.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/28545/#comment105823>
maybe append the family type here
3rdparty/libprocess/src/httpd.cpp
<https://reviews.apache.org/r/28545/#comment105825>
space before <
3rdparty/libprocess/src/net.hpp
<https://reviews.apache.org/r/28545/#comment105826>
you're in the process namespace.
3rdparty/libprocess/src/net.hpp
<https://reviews.apache.org/r/28545/#comment105827>
this cast makes me uncomfortable. should the Node constructor take an in_addr?
- Dominic Hamon
On Dec. 1, 2014, 6:07 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28545/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 6:07 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
> 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
> 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
> 3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
> 3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
>
> Diff: https://reviews.apache.org/r/28545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/
-----------------------------------------------------------
(Updated Dec. 2, 2014, 2:07 a.m.)
Review request for mesos, Dominic Hamon and Joris Van Remoortere.
Repository: mesos-git
Description
-------
Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
Diffs (updated)
-----
3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
Diff: https://reviews.apache.org/r/28545/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Dec. 1, 2014, 5:41 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 41
> > <https://reviews.apache.org/r/28545/diff/1/?file=778743#file778743line41>
> >
> > why are these inline?
>
> Evelina Dumitrescu wrote:
> If I remove inline, the linker complains abot this.
>
> Dominic Hamon wrote:
> right, because they're in a header. Why are they in a header at all instead of in the .cpp file?
I have discussed with Jorris this problem. Temporary we'll leave them in socket.hpp.
> On Dec. 1, 2014, 5:41 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 43
> > <https://reviews.apache.org/r/28545/diff/1/?file=778743#file778743line43>
> >
> > a switch might read better
done
> On Dec. 1, 2014, 5:41 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/net.hpp, line 47
> > <https://reviews.apache.org/r/28545/diff/1/?file=778746#file778746line47>
> >
> > you're in the process namespace, right?
done
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/#review63383
-----------------------------------------------------------
On Dec. 2, 2014, 2:07 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28545/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 2:07 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
> 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
> 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
> 3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
> 3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
>
> Diff: https://reviews.apache.org/r/28545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Dec. 1, 2014, 9:41 a.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 41
> > <https://reviews.apache.org/r/28545/diff/1/?file=778743#file778743line41>
> >
> > why are these inline?
>
> Evelina Dumitrescu wrote:
> If I remove inline, the linker complains abot this.
right, because they're in a header. Why are they in a header at all instead of in the .cpp file?
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/#review63383
-----------------------------------------------------------
On Nov. 30, 2014, 8:30 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28545/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2014, 8:30 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
> 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
> 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
> 3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
> 3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
>
> Diff: https://reviews.apache.org/r/28545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Dec. 1, 2014, 5:41 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/net.hpp, line 49
> > <https://reviews.apache.org/r/28545/diff/1/?file=778746#file778746line49>
> >
> > hm. i don't think we work that often with exceptions. maybe this should be reworked to return an Error instead.
Btw, do we still need the code from 3rdparty/libprocess/src/httpd.cpp and 3rdparty/libprocess/src/net.hpp?
> On Dec. 1, 2014, 5:41 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 41
> > <https://reviews.apache.org/r/28545/diff/1/?file=778743#file778743line41>
> >
> > why are these inline?
If I remove inline, the linker complains abot this.
> On Dec. 1, 2014, 5:41 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 60
> > <https://reviews.apache.org/r/28545/diff/1/?file=778743#file778743line60>
> >
> > will this take a family eventually? might be worth taking it now.
> >
> > otherwise, will it try to do both ipv4 and ipv6?
> >
> > if you want, take a look at https://github.com/m-lab/libraries for one way to handle ipv4 and ipv6 sockets gracefully.
Node will contain a field net::IP for the ip address. net::IP will contain the family type.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/#review63383
-----------------------------------------------------------
On Dec. 1, 2014, 4:30 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28545/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 4:30 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
> 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
> 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
> 3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
> 3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
>
> Diff: https://reviews.apache.org/r/28545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/#review63383
-----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/28545/#comment105627>
why are these inline?
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/28545/#comment105629>
a switch might read better
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/28545/#comment105628>
watch the formatting here and throughout. try clang-format to make your life easier.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/28545/#comment105631>
will this take a family eventually? might be worth taking it now.
otherwise, will it try to do both ipv4 and ipv6?
if you want, take a look at https://github.com/m-lab/libraries for one way to handle ipv4 and ipv6 sockets gracefully.
3rdparty/libprocess/src/net.hpp
<https://reviews.apache.org/r/28545/#comment105634>
you're in the process namespace, right?
3rdparty/libprocess/src/net.hpp
<https://reviews.apache.org/r/28545/#comment105635>
hm. i don't think we work that often with exceptions. maybe this should be reworked to return an Error instead.
- Dominic Hamon
On Nov. 30, 2014, 8:30 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28545/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2014, 8:30 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
> 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
> 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
> 3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
> 3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
>
> Diff: https://reviews.apache.org/r/28545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28545: Created accept, bind,
connect and getsockname wrappers for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28545/#review63392
-----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/28545/#comment105644>
Node will contain a field net::IP for the ip address. net::IP will contain the family type.
- Evelina Dumitrescu
On Dec. 1, 2014, 4:30 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28545/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 4:30 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol families
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
> 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
> 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
> 3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5
> 3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc
>
> Diff: https://reviews.apache.org/r/28545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>