You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by Cameron McCormack <ca...@mcc.id.au> on 2006/03/06 01:55:33 UTC
Updating rhino (was: svn commit: ...)
Cameron McCormack:
[... about updating rhino ...]
> > If not I'll do some testing and if all is well, update the jar
> > in the respository.
Thomas Deweese:
> Sounds good to me.
Ok, I have made changes that lets Rhino 1.6R2 work well with Batik.
However, there were some changes to the debugger which made it
impossible to use without modification. I submitted a patch to the
Rhino people, but I don't know if/when it will be accepted. Is it OK to
include my patched CVS snapshot of js.jar in the repository? Should I
somehow keep the modifications in there, too?
Thanks,
Cameron
--
Cameron McCormack ICQ: 26955922
cam (at) mcc.id.au MSN: cam (at) mcc.id.au
http://mcc.id.au/ JBR: heycam (at) jabber.org
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Updating rhino (was: svn commit: ...)
Posted by Cameron McCormack <ca...@mcc.id.au>.
thomas.deweese@kodak.com:
> This is tricky since the NPL/MPL has some kind of 'recontribution'
> requirement...
>
> What does the patch look like? Is it significant? or twiddling
> public/private adding accessor type stuff? Can you put up either on
> the Wiki or Bugzilla (you could use theirs I suppose)?
The patch I submitted to them involved some accessor twiddling and
accessor method additions. Also a couple of methods to allow the
debugger to detach from a script. The patch itself is quite huge,
though, since I also cleaned up and reordered the code a bit and added
some javadoc comments. Unfortunately that kind of obscures the
important changes I made to the code.
The patch is here:
https://bugzilla.mozilla.org/attachment.cgi?id=214133&action=view
--
Cameron McCormack ICQ: 26955922
cam (at) mcc.id.au MSN: cam (at) mcc.id.au
http://mcc.id.au/ JBR: heycam (at) jabber.org
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Updating rhino (was: svn commit: ...)
Posted by th...@kodak.com.
Hi Cameron,
Cameron McCormack <ca...@mcc.id.au> wrote on 03/05/2006 07:55:33 PM:
> Ok, I have made changes that lets Rhino 1.6R2 work well with Batik.
> However, there were some changes to the debugger which made it
> impossible to use without modification. I submitted a patch to the
> Rhino people, but I don't know if/when it will be accepted. Is it OK to
> include my patched CVS snapshot of js.jar in the repository? Should I
> somehow keep the modifications in there, too?
This is tricky since the NPL/MPL has some kind of 'recontribution'
requirement...
What does the patch look like? Is it significant? or twiddling
public/private adding accessor type stuff? Can you put up either on
the Wiki or Bugzilla (you could use theirs I suppose)?
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org