You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/15 15:14:05 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25463:
[SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
dongjoon-hyun commented on a change in pull request #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
URL: https://github.com/apache/spark/pull/25463#discussion_r314357247
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalogSuite.scala
##########
@@ -30,12 +30,12 @@ import org.apache.spark.sql.catalog.v2.{Catalogs, Identifier, TableCatalog, Tabl
import org.apache.spark.sql.catalyst.analysis.{NoSuchTableException, TableAlreadyExistsException}
import org.apache.spark.sql.catalyst.parser.CatalystSqlParser
import org.apache.spark.sql.internal.SQLConf
-import org.apache.spark.sql.test.SharedSQLContext
+import org.apache.spark.sql.test.SharedSparkSession
import org.apache.spark.sql.types.{DoubleType, IntegerType, LongType, StringType, StructField, StructType, TimestampType}
import org.apache.spark.sql.util.CaseInsensitiveStringMap
class V2SessionCatalogSuite
- extends SparkFunSuite with SharedSQLContext with BeforeAndAfter with BeforeAndAfterAll {
Review comment:
nit.
```
- import org.scalatest.{BeforeAndAfter, BeforeAndAfterAll}
+ import org.scalatest.BeforeAndAfter
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org