You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "leosanqing (via GitHub)" <gi...@apache.org> on 2023/05/26 07:39:39 UTC

[GitHub] [hudi] leosanqing opened a new pull request, #8816: Update syncing_metastore.md

leosanqing opened a new pull request, #8816:
URL: https://github.com/apache/hudi/pull/8816

    Fixes an incorrect field description on the page.
   
   ### Change Logs
   
    Fixes an incorrect field description on the website.
   
   ### Impact
   
   NONE
   
   ### Risk level (write none, low medium or high below)
   
   NONE
   
   ### Documentation Update
   
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [x] Adequate tests were added if applicable
   - [x] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] leosanqing closed pull request #8816: Update syncing_metastore.md

Posted by "leosanqing (via GitHub)" <gi...@apache.org>.
leosanqing closed pull request #8816: Update syncing_metastore.md
URL: https://github.com/apache/hudi/pull/8816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on a diff in pull request #8816: [DOCS] Update syncing_metastore.md

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8816:
URL: https://github.com/apache/hudi/pull/8816#discussion_r1206603576


##########
website/docs/syncing_metastore.md:
##########
@@ -157,7 +157,7 @@ WITH (
   'path' = '${db_path}/t1',
   'table.type' = 'COPY_ON_WRITE',  --If MERGE_ON_READ, hive query will not have output until the parquet file is generated
   'hive_sync.enable' = 'true',     -- Required. To enable hive synchronization
-  'hive_sync.mode' = 'jdbc',       -- Required. Setting hive sync mode to hms, default jdbc
+  'hive_sync.mode' = 'jdbc',       -- Required. Setting hive sync mode to jdbc, default hms. (Before 0.13, the default sync mode was jdbc.)
   'hive_sync.metastore.uris' = 'thrift://${ip}:9083', -- Required. The port need set on hive-site.xml
   'hive_sync.jdbc_url'='jdbc:hive2://${ip}:10000',    -- required, hiveServer port

Review Comment:
   Thanks, can we also update the doc of release 0.13.x.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 merged pull request #8816: [DOCS] Update syncing_metastore.md

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8816:
URL: https://github.com/apache/hudi/pull/8816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org