You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/30 06:30:17 UTC
[GitHub] [incubator-devlake] thenicetgp opened a new pull request, #2393: issue2268 solution draft
thenicetgp opened a new pull request, #2393:
URL: https://github.com/apache/incubator-devlake/pull/2393
# Summary
1. creator_id, creator_name, and assignee_id,author_id have values in table,
2. creator_id and author_id are the FK to table.users(after v0.12 is table.account)
3. add a column type in domain layer's table.pull_request_comments
### Does this close any open issues?
#2268
### Screenshots
### Other Information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on pull request #2393: issue2268 solution draft
Posted by GitBox <gi...@apache.org>.
warren830 commented on PR #2393:
URL: https://github.com/apache/incubator-devlake/pull/2393#issuecomment-1173495842
will be fixed in #2407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 closed pull request #2393: issue2268 solution draft
Posted by GitBox <gi...@apache.org>.
warren830 closed pull request #2393: issue2268 solution draft
URL: https://github.com/apache/incubator-devlake/pull/2393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mappjzc commented on pull request #2393: issue2268 solution draft
Posted by GitBox <gi...@apache.org>.
mappjzc commented on PR #2393:
URL: https://github.com/apache/incubator-devlake/pull/2393#issuecomment-1171856613
please check the test-e2e, lint-commit-message and golangci-lint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2393: issue2268 solution draft
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2393:
URL: https://github.com/apache/incubator-devlake/pull/2393#discussion_r911686153
##########
plugins/gitlab/tasks/issue_extractor.go:
##########
@@ -54,8 +55,8 @@ type IssuesResponse struct {
WebUrl string
AvatarUrl string
Username string
- Id int
- Name string
+ Id int `json:"creator_id"`
+ Name string `json:"creator_id"`
Review Comment:
JSON is duplicated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org