You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/16 09:51:42 UTC

[GitHub] [pulsar] tisonkun opened a new pull request, #17696: [improve][test] remove powermock-reflect dependency

tisonkun opened a new pull request, #17696:
URL: https://github.com/apache/pulsar/pull/17696

   This closes #16912.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #17696: [improve][test] remove powermock-reflect dependency

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17696:
URL: https://github.com/apache/pulsar/pull/17696#issuecomment-1250035170

   Thanks for your reviews! Could You help with merging this patch? @Shoothzj @nicoloboschi
   
   > LGTM but tbh it's a very long pull ๐Ÿ‘€
   
   As long as we use squash and merge๐Ÿ˜‰
   
   We should try to prevent reintroduce the library in further development randomly. And perhaps it's time to convert the "community" page to a contributor guide, like https://inlong.apache.org/community/how-to-contribute.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #17696: [improve][test] remove powermock-reflect dependency

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17696:
URL: https://github.com/apache/pulsar/pull/17696#issuecomment-1249491946

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #17696: [improve][test] remove powermock-reflect dependency

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17696:
URL: https://github.com/apache/pulsar/pull/17696#issuecomment-1249523543

   cc @Shoothzj @merlimat @nicoloboschi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi merged pull request #17696: [improve][test] remove powermock-reflect dependency

Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #17696:
URL: https://github.com/apache/pulsar/pull/17696


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org