You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by huafengw <gi...@git.apache.org> on 2017/09/01 06:22:01 UTC
[GitHub] incubator-gearpump pull request #222: [GEARPUMP-348] Allow application total...
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/222
[GEARPUMP-348] Allow application total number of retries to be config…
…urable
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator-gearpump restart
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/222.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #222
----
commit 1ff5ac05904320fd64580529897822524edb349a
Author: huafengw <fv...@gmail.com>
Date: 2017-09-01T06:21:19Z
[GEARPUMP-348] Allow application total number of retries to be configurable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #222: [GEARPUMP-348] Allow application total number...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/222
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #222: [GEARPUMP-348] Allow application total number...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/222
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/222?src=pr&el=h1) Report
> Merging [#222](https://codecov.io/gh/apache/incubator-gearpump/pull/222?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/995c8cc0cc0b18dd30cbbe218972b0bded297ff0?src=pr&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `100%`.
```diff
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 69.42% 69.56% +0.13%
==========================================
Files 191 191
Lines 6103 6104 +1
Branches 362 350 -12
==========================================
+ Hits 4237 4246 +9
+ Misses 1866 1858 -8
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #222: [GEARPUMP-348] Allow application total...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---