You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:03:12 UTC
[GitHub] [incubator-mxnet] szha opened a new pull request #18404: try without force inline
szha opened a new pull request #18404:
URL: https://github.com/apache/incubator-mxnet/pull/18404
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] JiangZhaoh commented on pull request #18404: try without force inline
Posted by GitBox <gi...@apache.org>.
JiangZhaoh commented on pull request #18404:
URL: https://github.com/apache/incubator-mxnet/pull/18404#issuecomment-634465972
Sorry but I can't reproduce the CI compile issue.
I use **Deep Learning AMI (Ubuntu 18.04) Version 29.0 (ami-0ffd41ee43c386b23)** as my local machine and the build command as follows:
```
make clean
rm -rf build
mkdir -p build && cd build
cmake -DUSE_OPENCV=0 \
-DUSE_CUDA=1 \
-DUSE_CUDA_PATH=/usr/local/cuda \
-DUSE_CUDNN=1 \
-DUSE_MKLDNN=0 \
-DCMAKE_BUILD_TYPE=RELEASE \
-DBUILD_CYTHON_MODULES=ON \
-GNinja ..
ninja
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18404: try without force inline
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18404:
URL: https://github.com/apache/incubator-mxnet/pull/18404#issuecomment-634893812
@JiangZhaoh you will need to use gcc-7 for getting the warning. I was able to obtain the warning on mac by installing `brew install gcc@7` and specify `CC=gcc-7 CXX=g++-7`. The builds in CI failed because we have `-Werror` on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18404: try without force inline
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18404:
URL: https://github.com/apache/incubator-mxnet/pull/18404#issuecomment-633713688
Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, miscellaneous, centos-cpu, windows-gpu, edge, windows-cpu, unix-gpu, unix-cpu, website, clang, centos-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha closed pull request #18404: try without force inline
Posted by GitBox <gi...@apache.org>.
szha closed pull request #18404:
URL: https://github.com/apache/incubator-mxnet/pull/18404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18404: try without force inline
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18404:
URL: https://github.com/apache/incubator-mxnet/pull/18404#issuecomment-633738244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] JiangZhaoh edited a comment on pull request #18404: try without force inline
Posted by GitBox <gi...@apache.org>.
JiangZhaoh edited a comment on pull request #18404:
URL: https://github.com/apache/incubator-mxnet/pull/18404#issuecomment-634465972
Sorry but I can't reproduce the CI compile issue.
I made the same change as your commit in master branch, it can build successfully.
I use **Deep Learning AMI (Ubuntu 18.04) Version 29.0 (ami-0ffd41ee43c386b23)** as my local machine and the build command as follows:
```
make clean
rm -rf build
mkdir -p build && cd build
cmake -DUSE_OPENCV=0 \
-DUSE_CUDA=1 \
-DUSE_CUDA_PATH=/usr/local/cuda \
-DUSE_CUDNN=1 \
-DUSE_MKLDNN=0 \
-DCMAKE_BUILD_TYPE=RELEASE \
-DBUILD_CYTHON_MODULES=ON \
-GNinja ..
ninja
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org