[jira] [Commented] (PHOENIX-5405) Enable timerange in sql hint

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899671#comment-16899671 ] 

Hadoop QA commented on PHOENIX-5405:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12976642/PHOENIX-5405-v2.patch
  against master branch at commit 12c538ce2db4779b91bc294ebe8e4880673ff8c2.
  ATTACHMENT ID: 12976642

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        ConnectionQueryServices services = driver.getConnectionQueryServices(getUrl(), PropertiesUtil.deepCopy(TEST_PROPERTIES));
+            String sql2 = "SELECT /*+" + HintNode.Hint.DATA_TIME_RANGE + "(0, 101) */  A, B FROM " + tableName;
+            String sql3 = "SELECT /*+" + HintNode.Hint.DATA_TIME_RANGE + "(0, 100) */  A, B FROM " + tableName;

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2874//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2874//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2874//console

This message is automatically generated.

> Enable timerange in sql hint
> ----------------------------
>
>                 Key: PHOENIX-5405
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5405
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Chen Feng
>            Priority: Minor
>         Attachments: PHOENIX-5405-v1.patch, PHOENIX-5405-v2.patch
>
>
> PHOENIX-914 enabled Native HBase timestamp support to optimize date range queries in Phoenix.
> However, the end time is set at the beginning of connection. For a long term connection, we cannot change SCN during processing.
> If we have knowledge of underly HBase timestamp, we can use a connection-free way to query the target data by adding a hint in sql.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)