You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/24 21:18:29 UTC
[GitHub] [hudi] xushiyan opened a new pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
xushiyan opened a new pull request #4680:
URL: https://github.com/apache/hudi/pull/4680
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#discussion_r793305258
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -458,7 +458,7 @@ protected static int upgradeOrDowngradeTable(JavaSparkContext jsc, String basePa
.setLoadActiveTimelineOnLoad(false).setConsistencyGuardConfig(config.getConsistencyGuardConfig())
.setLayoutVersion(Option.of(new TimelineLayoutVersion(config.getTimelineLayoutVersion()))).build();
try {
- new UpgradeDowngrade(metaClient, config, new HoodieSparkEngineContext(jsc), SparkUpgradeDowngradeHelper.getInstance())
+ new Versioner(metaClient, config, new HoodieSparkEngineContext(jsc), SparkUpgradeDowngradeHelper.getInstance())
Review comment:
Not a strong opinion. I see you renamed upgrade- and downgrade-related classes. This isn't in the scope of the class renaming originally. If we agree that the new names are better, we can keep them in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1023749306
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
}, {
"hash" : "5d9189c4f457e5877280f00d0dcd9ccdb476135f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5565",
"triggerID" : "5d9189c4f457e5877280f00d0dcd9ccdb476135f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5593a7e380700e7f89c65b44b20dfa4d31a15ea9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481)
* 5d9189c4f457e5877280f00d0dcd9ccdb476135f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5565)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020560620
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c0772c7406df1ffca39bf75de7d747914be0b26 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1023727107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
}, {
"hash" : "5d9189c4f457e5877280f00d0dcd9ccdb476135f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5d9189c4f457e5877280f00d0dcd9ccdb476135f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5593a7e380700e7f89c65b44b20dfa4d31a15ea9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481)
* 5d9189c4f457e5877280f00d0dcd9ccdb476135f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#discussion_r794077206
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/OneToZeroDowngrader.java
##########
@@ -35,13 +35,13 @@
/**
* Downgrade handle to assist in downgrading hoodie table from version 1 to 0.
*/
-public class OneToZeroDowngradeHandler implements DowngradeHandler {
+public class OneToZeroDowngrader implements Downgrader {
Review comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020568828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c0772c7406df1ffca39bf75de7d747914be0b26 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478)
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5593a7e380700e7f89c65b44b20dfa4d31a15ea9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020560620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1023749306
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
}, {
"hash" : "5d9189c4f457e5877280f00d0dcd9ccdb476135f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5565",
"triggerID" : "5d9189c4f457e5877280f00d0dcd9ccdb476135f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5593a7e380700e7f89c65b44b20dfa4d31a15ea9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481)
* 5d9189c4f457e5877280f00d0dcd9ccdb476135f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5565)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020560620
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c0772c7406df1ffca39bf75de7d747914be0b26 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#discussion_r794077113
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -458,7 +458,7 @@ protected static int upgradeOrDowngradeTable(JavaSparkContext jsc, String basePa
.setLoadActiveTimelineOnLoad(false).setConsistencyGuardConfig(config.getConsistencyGuardConfig())
.setLayoutVersion(Option.of(new TimelineLayoutVersion(config.getTimelineLayoutVersion()))).build();
try {
- new UpgradeDowngrade(metaClient, config, new HoodieSparkEngineContext(jsc), SparkUpgradeDowngradeHelper.getInstance())
+ new Versioner(metaClient, config, new HoodieSparkEngineContext(jsc), SparkUpgradeDowngradeHelper.getInstance())
Review comment:
Reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1023727107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
}, {
"hash" : "5d9189c4f457e5877280f00d0dcd9ccdb476135f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5d9189c4f457e5877280f00d0dcd9ccdb476135f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5593a7e380700e7f89c65b44b20dfa4d31a15ea9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481)
* 5d9189c4f457e5877280f00d0dcd9ccdb476135f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020568828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c0772c7406df1ffca39bf75de7d747914be0b26 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478)
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5593a7e380700e7f89c65b44b20dfa4d31a15ea9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020675983
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5593a7e380700e7f89c65b44b20dfa4d31a15ea9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020613376
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c0772c7406df1ffca39bf75de7d747914be0b26 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478)
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5593a7e380700e7f89c65b44b20dfa4d31a15ea9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020675983
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5593a7e380700e7f89c65b44b20dfa4d31a15ea9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020566472
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c0772c7406df1ffca39bf75de7d747914be0b26 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478)
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020564071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c0772c7406df1ffca39bf75de7d747914be0b26 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020560620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
yihua merged pull request #4680:
URL: https://github.com/apache/hudi/pull/4680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#discussion_r794094605
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/AsyncClusteringService.java
##########
@@ -19,8 +19,8 @@
package org.apache.hudi.async;
-import org.apache.hudi.client.AbstractClusteringClient;
-import org.apache.hudi.client.AbstractHoodieWriteClient;
+import org.apache.hudi.client.BaseClusterer;
Review comment:
As discussed, the clustering client is used internally for clustering table service. The purpose of the renaming to BaseClusterer is to distinguish it from external-facing read and write client and make it consistent with Compactor and Cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020613376
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c0772c7406df1ffca39bf75de7d747914be0b26 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478)
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5593a7e380700e7f89c65b44b20dfa4d31a15ea9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#discussion_r793319709
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/AsyncClusteringService.java
##########
@@ -19,8 +19,8 @@
package org.apache.hudi.async;
-import org.apache.hudi.client.AbstractClusteringClient;
-import org.apache.hudi.client.AbstractHoodieWriteClient;
+import org.apache.hudi.client.BaseClusterer;
Review comment:
`BaseClusteringClient`?
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/userdefined/AbstractUserDefinedMetricsReporter.java
##########
@@ -7,38 +7,31 @@
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
*/
package org.apache.hudi.metrics.userdefined;
+import org.apache.hudi.metrics.custom.CustomizableMetricsReporter;
+
import com.codahale.metrics.MetricRegistry;
-import org.apache.hudi.metrics.MetricsReporter;
+
import java.util.Properties;
/**
- * Abstract class of user defined metrics reporter.
+ * @deprecated Extend {@link CustomizableMetricsReporter} instead.
*/
-public abstract class AbstractUserDefinedMetricsReporter extends MetricsReporter {
- private Properties props;
- private MetricRegistry registry;
+@Deprecated
+public abstract class AbstractUserDefinedMetricsReporter extends CustomizableMetricsReporter {
Review comment:
Great that the backward compatibility is considered :)
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -458,7 +458,7 @@ protected static int upgradeOrDowngradeTable(JavaSparkContext jsc, String basePa
.setLoadActiveTimelineOnLoad(false).setConsistencyGuardConfig(config.getConsistencyGuardConfig())
.setLayoutVersion(Option.of(new TimelineLayoutVersion(config.getTimelineLayoutVersion()))).build();
try {
- new UpgradeDowngrade(metaClient, config, new HoodieSparkEngineContext(jsc), SparkUpgradeDowngradeHelper.getInstance())
+ new Versioner(metaClient, config, new HoodieSparkEngineContext(jsc), SparkUpgradeDowngradeHelper.getInstance())
Review comment:
Not a strong opinion. I see you renamed upgrade- and downgrade-related classes. This isn't in the scope of the class renaming originally. If we agree that the new names are better,
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/OneToZeroDowngrader.java
##########
@@ -35,13 +35,13 @@
/**
* Downgrade handle to assist in downgrading hoodie table from version 1 to 0.
*/
-public class OneToZeroDowngradeHandler implements DowngradeHandler {
+public class OneToZeroDowngrader implements Downgrader {
Review comment:
I’m not in favor of `<verb>-er` naming pattern. We can discuss how such classes can be renamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1023785526
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
}, {
"hash" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5481",
"triggerID" : "5593a7e380700e7f89c65b44b20dfa4d31a15ea9",
"triggerType" : "PUSH"
}, {
"hash" : "5d9189c4f457e5877280f00d0dcd9ccdb476135f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5565",
"triggerID" : "5d9189c4f457e5877280f00d0dcd9ccdb476135f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
* 5d9189c4f457e5877280f00d0dcd9ccdb476135f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5565)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020566472
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
}, {
"hash" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae88c2fc58bf07a435feb971435646258e2b5e87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c0772c7406df1ffca39bf75de7d747914be0b26 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478)
* ae88c2fc58bf07a435feb971435646258e2b5e87 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4680: [HUDI-2596] Make class names consistent in hudi-client
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#issuecomment-1020564071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478",
"triggerID" : "5c0772c7406df1ffca39bf75de7d747914be0b26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c0772c7406df1ffca39bf75de7d747914be0b26 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5478)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org